[PM-13938] Changes to disabled user from seeing password that they shouldn't see or edit easily.

[cd-bitwarden]

… or edit easily.

🎟️ Tracking

📔 Objective

Expected: To not be able to toggle a custom hidden field from View item or Edit item screen.

Expected to be able to edit custom hidden field label but NOT the value.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ffa5afb). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #12161   +/-   ##
=======================================
  Coverage        ?   34.33%           
=======================================
  Files           ?     2965           
  Lines           ?    90533           
  Branches        ?    16977           
=======================================
  Hits            ?    31087           
  Misses          ?    56982           
  Partials        ?     2464           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gbubemismith]

@cd-bitwarden I don't think this solution works on the web for can edit, except passwords

[github-actions]

Checkmarx One – Scan Summary & Details – f8cd1408-0230-4d6a-b2c0-e70aa8d0a190

Great job, no security vulnerabilities found in this Pull Request

[cd-bitwarden]

@gbubemismith After QA review I've updated the code so that it doesn't disable the view pwd toggle, and the copy button : it instead hides those options when unavailable. Now the custom fields hidden fields area looks and acts like other password fields on the cipher.

[gbubemismith]

A test is failing

[cd-bitwarden]

A test is failing

I have fixed the test 😄 thank you