Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13938] Changes to disabled user from seeing password that they shouldn't see or edit easily. #12161

Merged
merged 15 commits into from
Jan 21, 2025
Merged

[PM-13938] Changes to disabled user from seeing password that they shouldn't see or edit easily. #12161

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e063c3d
Changes to disabled user from seeing password that they shouldn't see…
Nov 26, 2024
9dcd108
Merge branch 'main' into PM-13938-exceptPasswordPermission
cd-bitwarden Dec 4, 2024
5d5d621
Merge branch 'main' into PM-13938-exceptPasswordPermission
cd-bitwarden Dec 10, 2024
a8c1f5c
Merge branch 'main' into PM-13938-exceptPasswordPermission
cd-bitwarden Dec 12, 2024
95c5435
Merge branch 'main' into PM-13938-exceptPasswordPermission
kejaeger Dec 16, 2024
854ae5b
Merge branch 'main' into PM-13938-exceptPasswordPermission
Dec 17, 2024
4525dbc
Fixing defects on PM-13938
Dec 18, 2024
6c61320
undoing unecessary change
Dec 18, 2024
c15d193
Merge branch 'main' into PM-13938-exceptPasswordPermission
cd-bitwarden Dec 18, 2024
30bc31e
Updating tests
Dec 19, 2024
f707862
Merge branch 'main' into PM-13938-exceptPasswordPermission
cd-bitwarden Dec 20, 2024
1f72d99
Merge branch 'main' into PM-13938-exceptPasswordPermission
cd-bitwarden Dec 20, 2024
3b54f8f
Merge branch 'main' into PM-13938-exceptPasswordPermission
cd-bitwarden Dec 20, 2024
07419c0
Merge branch 'main' into PM-13938-exceptPasswordPermission
cd-bitwarden Jan 9, 2025
264bb4a
Merge branch 'main' into PM-13938-exceptPasswordPermission
cd-bitwarden Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/vault/src/cipher-form/components/custom-fields/custom-fields.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ <h2 bitTypography="h6">{{ "customFields" | i18n }}</h2>
bitSuffix
bitPasswordInputToggle
data-testid="visibility-for-custom-hidden-field"
[disabled]="!canViewPasswords(i)"
*ngIf="canViewPasswords(i)"
(toggledChange)="logHiddenEvent($event)"
></button>
</bit-form-field>
Expand Down
2 changes: 2 additions & 0 deletions libs/vault/src/cipher-view/custom-fields/custom-fields-v2.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,15 @@ <h2 bitTypography="h6">{{ "customFields" | i18n }}</h2>
<button
bitSuffix
type="button"
*ngIf="this.cipher.viewPassword"
bitIconButton
bitPasswordInputToggle
(toggledChange)="logHiddenEvent($event)"
></button>
<button
bitIconButton="bwi-clone"
bitSuffix
*ngIf="this.cipher.viewPassword"
type="button"
[appCopyClick]="field.value"
showToast
Expand Down
Loading