Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust handling of GH action dependencies for CI/CD partnership #12818

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Jan 12, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14640

📔 Objective

As we have started to share ownership of our build pipelines between BRE and Platform, BRE no longer owns all of the github-action-managed dependencies. The current renovate.json results in misleading PR titles like #12706.

This PR does the following:

  • Removes the addition of the BRE prefix for all github-action dependencies.
  • Removes patch updates from the scope of PR creation.

❓ What will upcoming PRs look like?

  • Patch updates will be ignored
  • Minor updates will be grouped into a single PR, with no team-specific prefix, with the PR reviewer(s) determined by who owns the workflow files in which the dependencies are used (e.g. Platform would need to review build/lint/test workflows, BRE would need to review deploy/publish workflows).
    • 🤔 Note that we can do this since the workflow files have explicit CODEOWNERs defined, whereas other dependencies are updated in package.json which doesn't have an owner, so we have to assign the ownership in renovate.json.
  • Major updates will be handled independently with PRs for each, with no team-specific prefix with the PR reviewer(s) determined by who owns the workflow files in which the dependencies are used

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Clean up handling of GH action dependencies Adjust handling of GH action dependencies for CI/CD partnership Jan 12, 2025
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details3335dfa2-9d15-45f3-9eec-027302d7dfc5

Great job, no security vulnerabilities found in this Pull Request

@trmartin4 trmartin4 marked this pull request as ready for review January 12, 2025 21:45
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.13%. Comparing base (e1434d8) to head (98742e7).
Report is 60 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12818   +/-   ##
=======================================
  Coverage   34.13%   34.13%           
=======================================
  Files        2936     2936           
  Lines       90435    90435           
  Branches    16989    16989           
=======================================
  Hits        30869    30869           
  Misses      57109    57109           
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trmartin4 trmartin4 requested review from a team and addisonbeck January 15, 2025 16:44
@trmartin4 trmartin4 merged commit 1916fdc into main Jan 15, 2025
27 checks passed
@trmartin4 trmartin4 deleted the platform/github-action-renovate-updates branch January 15, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants