Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-4300] downgrade Electron to v25.9.1 #6573

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[PM-4300] downgrade Electron to v25.9.1 #6573

merged 1 commit into from
Oct 13, 2023

Conversation

willmartian
Copy link
Contributor

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Downgrades Electron from v26.3.0 to v25.9.1.

Resolves #6560

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@willmartian willmartian requested a review from a team as a code owner October 13, 2023 02:25
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Oct 13, 2023
@willmartian willmartian requested a review from Hinton October 13, 2023 02:26
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – a811e558-1209-41f7-9f6d-b5ded0ad48fb

No New Or Fixed Issues Found

Hinton
Hinton approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we have a month or two before we'll have to upgrade again.

@willmartian willmartian removed the needs-qa Marks a PR as requiring QA approval label Oct 13, 2023
@willmartian willmartian merged commit bb9de00 into master Oct 13, 2023
@willmartian willmartian deleted the ps/PM-4300/downgrade-electron branch October 13, 2023 14:26
willmartian added a commit that referenced this pull request Oct 13, 2023
@willmartian
[PM-4300] downgrade electron to v25.9.1 (#6573)
49099b7 
(cherry picked from commit bb9de00)
@withinfocus withinfocus mentioned this pull request Oct 17, 2023
Merged
BlackDex pushed a commit to BlackDex/bitwarden-clients that referenced this pull request Nov 21, 2023
@willmartian @BlackDex
[PM-4300] downgrade electron to v25.9.1 (bitwarden#6573)
da13c44
@SuperSandro2000
Copy link

Is there an issue or PR I can follow to track the update of the electron version?

@SuperSandro2000 SuperSandro2000 mentioned this pull request Dec 7, 2023
Closed
13 tasks
@djsmith85
Copy link
Contributor

@SuperSandro2000

Is there an issue or PR I can follow to track the update of the electron version?

The update to electron 27.1.3 just got merged with #7134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hinton Hinton Hinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux Desktop Client blanks out when entering vault key
5 participants
@willmartian @bitwarden-bot @SuperSandro2000 @djsmith85 @Hinton