Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5149] UI for unique SP entity id on organization sso configs #7117

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

kspearrin
Copy link
Member

@kspearrin kspearrin commented Dec 6, 2023

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Sometimes customers have a shared IdP tenant and need multiple Bitwarden Organizations. In order to enable this use case for SSO, we need to generate a unique SP entity ID per organization.

Right now, it’s a generic standard ID (https://sso.bitwarden.com/saml2). We should update the ID to be unique with the org id included (https://sso.bitwarden.com/saml2/org-id).

We also have to support customers that are already configured using the old-style ID, so a new checkbox option as added to opt-into this new unique SP entity id format. New customers will be opted-in automatically.

Code changes

  • apps/web/src/locales/en/messages.json: New translations for the checkbox.
  • bitwarden_license/bit-web/src/app/auth/sso/sso.component.html: Add the checkbox option for spUniqueEntityId. Add a readonly field that displays the unique sp entity id URL when the option is checked.
  • bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts: Wire up spUniqueEntityId to the form builder.
  • libs/common/src/auth/models/api/sso-config.api.ts: Add spUniqueEntityId property and populate it with server returned value.
  • libs/common/src/auth/models/response/organization-sso.response.ts: Add spEntityIdStatic for the static URL vs unique one now located in spEntityId.
  • libs/common/src/auth/models/view/sso-config.view.ts: Extend the view with spUniqueEntityId

Screenshots

image

image

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Dec 6, 2023
@kspearrin kspearrin changed the title add ui for making sp entity id unique [PM-5149] add ui for making sp entity id unique Dec 6, 2023
@bitwarden-bot
Copy link

bitwarden-bot commented Dec 6, 2023

Logo
Checkmarx One – Scan Summary & Details21e00879-ba6c-4f53-afd7-99f54a904917

No New Or Fixed Issues Found

@kspearrin kspearrin changed the title [PM-5149] add ui for making sp entity id unique [PM-5149] UI for unique SP entity id on organization sso configs Dec 6, 2023
@kspearrin kspearrin marked this pull request as ready for review December 6, 2023 17:49
@kspearrin kspearrin requested a review from a team as a code owner December 6, 2023 17:49
@jlf0dev jlf0dev requested review from jlf0dev and removed request for JaredSnider-Bitwarden December 6, 2023 18:11
@kspearrin kspearrin removed the needs-qa Marks a PR as requiring QA approval label Jan 18, 2024
@kspearrin kspearrin enabled auto-merge (squash) January 18, 2024 21:54
@kspearrin kspearrin merged commit 06c7c3f into main Jan 18, 2024
69 of 71 checks passed
@kspearrin kspearrin deleted the spuniqueentityid branch January 18, 2024 21:54
cagonzalezcs pushed a commit that referenced this pull request Jan 22, 2024
* add ui for making sp entity id unique

* pretty

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants