Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mac handling in decrypting vault items to discard invalid items #516

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 19, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Tweaks the decryption logic to discard bad data rather than returning an error. We should re-evaluate this in the future and potentially include some metadata about the failure so that the applications can show a warning about corrupt data.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia January 19, 2024 14:55
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (b174e49) 50.05% compared to head (3488789) 50.01%.

Files Patch % Lines
crates/bitwarden/src/vault/cipher/identity.rs 0.00% 18 Missing ⚠️
crates/bitwarden/src/vault/cipher/cipher.rs 0.00% 12 Missing ⚠️
crates/bitwarden/src/vault/cipher/card.rs 0.00% 6 Missing ⚠️
crates/bitwarden/src/vault/cipher/login.rs 0.00% 4 Missing ⚠️
crates/bitwarden/src/vault/cipher/field.rs 0.00% 2 Missing ⚠️
crates/bitwarden/src/vault/collection.rs 0.00% 1 Missing ⚠️
crates/bitwarden/src/vault/folder.rs 0.00% 1 Missing ⚠️
crates/bitwarden/src/vault/password_history.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   50.05%   50.01%   -0.05%     
==========================================
  Files         161      161              
  Lines        7849     7862      +13     
==========================================
+ Hits         3929     3932       +3     
- Misses       3920     3930      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton merged commit 3689f59 into main Jan 19, 2024
54 of 55 checks passed
@Hinton Hinton deleted the ps/mac-validation branch January 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants