Update mac handling in decrypting vault items to discard invalid items

crates/bitwarden/src/vault/cipher/card.rs

@@ -47,12 +47,12 @@
 impl KeyDecryptable<SymmetricCryptoKey, CardView> for Card {
     fn decrypt_with_key(&self, key: &SymmetricCryptoKey) -> Result<CardView, CryptoError> {
         Ok(CardView {
-            cardholder_name: self.cardholder_name.decrypt_with_key(key)?,
-            exp_month: self.exp_month.decrypt_with_key(key)?,
-            exp_year: self.exp_year.decrypt_with_key(key)?,
-            code: self.code.decrypt_with_key(key)?,
-            brand: self.brand.decrypt_with_key(key)?,
-            number: self.number.decrypt_with_key(key)?,
+            cardholder_name: self.cardholder_name.decrypt_with_key(key).ok().flatten(),
+            exp_month: self.exp_month.decrypt_with_key(key).ok().flatten(),
+            exp_year: self.exp_year.decrypt_with_key(key).ok().flatten(),
+            code: self.code.decrypt_with_key(key).ok().flatten(),
+            brand: self.brand.decrypt_with_key(key).ok().flatten(),
+            number: self.number.decrypt_with_key(key).ok().flatten(),
         })
     }
 }

crates/bitwarden/src/vault/cipher/cipher.rs

@@ -182,22 +182,22 @@
             folder_id: self.folder_id,
             collection_ids: self.collection_ids.clone(),
             key: self.key.clone(),
-            name: self.name.decrypt_with_key(key)?,
-            notes: self.notes.decrypt_with_key(key)?,
+            name: self.name.decrypt_with_key(key).ok().unwrap_or_default(),
+            notes: self.notes.decrypt_with_key(key).ok().flatten(),
             r#type: self.r#type,
-            login: self.login.decrypt_with_key(key)?,
-            identity: self.identity.decrypt_with_key(key)?,
-            card: self.card.decrypt_with_key(key)?,
-            secure_note: self.secure_note.decrypt_with_key(key)?,
+            login: self.login.decrypt_with_key(key).ok().flatten(),
+            identity: self.identity.decrypt_with_key(key).ok().flatten(),
+            card: self.card.decrypt_with_key(key).ok().flatten(),
+            secure_note: self.secure_note.decrypt_with_key(key).ok().flatten(),
             favorite: self.favorite,
             reprompt: self.reprompt,
             organization_use_totp: self.organization_use_totp,
             edit: self.edit,
             view_password: self.view_password,
-            local_data: self.local_data.decrypt_with_key(key)?,
-            attachments: self.attachments.decrypt_with_key(key)?,
-            fields: self.fields.decrypt_with_key(key)?,
-            password_history: self.password_history.decrypt_with_key(key)?,
+            local_data: self.local_data.decrypt_with_key(key).ok().flatten(),
+            attachments: self.attachments.decrypt_with_key(key).ok().flatten(),
+            fields: self.fields.decrypt_with_key(key).ok().flatten(),
+            password_history: self.password_history.decrypt_with_key(key).ok().flatten(),
             creation_date: self.creation_date,
             deleted_date: self.deleted_date,
             revision_date: self.revision_date,
@@ -298,8 +298,8 @@
             organization_id: self.organization_id,
             folder_id: self.folder_id,
             collection_ids: self.collection_ids.clone(),
-            name: self.name.decrypt_with_key(key)?,
-            sub_title: self.get_decrypted_subtitle(key)?,
+            name: self.name.decrypt_with_key(key).ok().unwrap_or_default(),
+            sub_title: self.get_decrypted_subtitle(key).ok().unwrap_or_default(),
             r#type: self.r#type,
             favorite: self.favorite,
             reprompt: self.reprompt,

crates/bitwarden/src/vault/cipher/field.rs

@@ -55,8 +55,8 @@
 impl KeyDecryptable<SymmetricCryptoKey, FieldView> for Field {
     fn decrypt_with_key(&self, key: &SymmetricCryptoKey) -> Result<FieldView, CryptoError> {
         Ok(FieldView {
-            name: self.name.decrypt_with_key(key)?,
-            value: self.value.decrypt_with_key(key)?,
+            name: self.name.decrypt_with_key(key).ok().flatten(),
+            value: self.value.decrypt_with_key(key).ok().flatten(),
             r#type: self.r#type,
             linked_id: self.linked_id,
         })

crates/bitwarden/src/vault/cipher/identity.rs

@@ -83,24 +83,24 @@
 impl KeyDecryptable<SymmetricCryptoKey, IdentityView> for Identity {
     fn decrypt_with_key(&self, key: &SymmetricCryptoKey) -> Result<IdentityView, CryptoError> {
         Ok(IdentityView {
-            title: self.title.decrypt_with_key(key)?,
-            first_name: self.first_name.decrypt_with_key(key)?,
-            middle_name: self.middle_name.decrypt_with_key(key)?,
-            last_name: self.last_name.decrypt_with_key(key)?,
-            address1: self.address1.decrypt_with_key(key)?,
-            address2: self.address2.decrypt_with_key(key)?,
-            address3: self.address3.decrypt_with_key(key)?,
-            city: self.city.decrypt_with_key(key)?,
-            state: self.state.decrypt_with_key(key)?,
-            postal_code: self.postal_code.decrypt_with_key(key)?,
-            country: self.country.decrypt_with_key(key)?,
-            company: self.company.decrypt_with_key(key)?,
-            email: self.email.decrypt_with_key(key)?,
-            phone: self.phone.decrypt_with_key(key)?,
-            ssn: self.ssn.decrypt_with_key(key)?,
-            username: self.username.decrypt_with_key(key)?,
-            passport_number: self.passport_number.decrypt_with_key(key)?,
-            license_number: self.license_number.decrypt_with_key(key)?,
+            title: self.title.decrypt_with_key(key).ok().flatten(),
+            first_name: self.first_name.decrypt_with_key(key).ok().flatten(),
+            middle_name: self.middle_name.decrypt_with_key(key).ok().flatten(),
+            last_name: self.last_name.decrypt_with_key(key).ok().flatten(),
+            address1: self.address1.decrypt_with_key(key).ok().flatten(),
+            address2: self.address2.decrypt_with_key(key).ok().flatten(),
+            address3: self.address3.decrypt_with_key(key).ok().flatten(),
+            city: self.city.decrypt_with_key(key).ok().flatten(),
+            state: self.state.decrypt_with_key(key).ok().flatten(),
+            postal_code: self.postal_code.decrypt_with_key(key).ok().flatten(),
+            country: self.country.decrypt_with_key(key).ok().flatten(),
+            company: self.company.decrypt_with_key(key).ok().flatten(),
+            email: self.email.decrypt_with_key(key).ok().flatten(),
+            phone: self.phone.decrypt_with_key(key).ok().flatten(),
+            ssn: self.ssn.decrypt_with_key(key).ok().flatten(),
+            username: self.username.decrypt_with_key(key).ok().flatten(),
+            passport_number: self.passport_number.decrypt_with_key(key).ok().flatten(),
+            license_number: self.license_number.decrypt_with_key(key).ok().flatten(),
         })
     }
 }

crates/bitwarden/src/vault/cipher/login.rs

@@ -98,11 +98,11 @@
 impl KeyDecryptable<SymmetricCryptoKey, LoginView> for Login {
     fn decrypt_with_key(&self, key: &SymmetricCryptoKey) -> Result<LoginView, CryptoError> {
         Ok(LoginView {
-            username: self.username.decrypt_with_key(key)?,
-            password: self.password.decrypt_with_key(key)?,
+            username: self.username.decrypt_with_key(key).ok().flatten(),
+            password: self.password.decrypt_with_key(key).ok().flatten(),
             password_revision_date: self.password_revision_date,
-            uris: self.uris.decrypt_with_key(key)?,
-            totp: self.totp.decrypt_with_key(key)?,
+            uris: self.uris.decrypt_with_key(key).ok().flatten(),
+            totp: self.totp.decrypt_with_key(key).ok().flatten(),
             autofill_on_page_load: self.autofill_on_page_load,
         })
     }

crates/bitwarden/src/vault/collection.rs

@@ -51,7 +51,7 @@
             id: self.id,
             organization_id: self.organization_id,
 
-            name: self.name.decrypt_with_key(key)?,
+            name: self.name.decrypt_with_key(key).ok().unwrap_or_default(),
 
             external_id: self.external_id.clone(),
             hide_passwords: self.hide_passwords,

crates/bitwarden/src/vault/folder.rs

@@ -43,7 +43,7 @@
     fn decrypt_with_key(&self, key: &SymmetricCryptoKey) -> Result<FolderView, CryptoError> {
         Ok(FolderView {
             id: self.id,
-            name: self.name.decrypt_with_key(key)?,
+            name: self.name.decrypt_with_key(key).ok().unwrap_or_default(),
             revision_date: self.revision_date,
         })
     }

crates/bitwarden/src/vault/password_history.rs

@@ -41,7 +41,7 @@
         key: &SymmetricCryptoKey,
     ) -> Result<PasswordHistoryView, CryptoError> {
         Ok(PasswordHistoryView {
-            password: self.password.decrypt_with_key(key)?,
+            password: self.password.decrypt_with_key(key).ok().unwrap_or_default(),
             last_used_date: self.last_used_date,
         })
     }

crates/bitwarden/src/vault/send.rs

@@ -206,15 +206,15 @@ impl KeyDecryptable<SymmetricCryptoKey, SendView> for Send {
             id: self.id,
             access_id: self.access_id.clone(),
 
-            name: self.name.decrypt_with_key(&key)?,
-            notes: self.notes.decrypt_with_key(&key)?,
+            name: self.name.decrypt_with_key(&key).ok().unwrap_or_default(),
+            notes: self.notes.decrypt_with_key(&key).ok().flatten(),
             key: Some(URL_SAFE_NO_PAD.encode(k)),
             new_password: None,
             has_password: self.password.is_some(),
 
             r#type: self.r#type,
-            file: self.file.decrypt_with_key(&key)?,
-            text: self.text.decrypt_with_key(&key)?,
+            file: self.file.decrypt_with_key(&key).ok().flatten(),
+            text: self.text.decrypt_with_key(&key).ok().flatten(),
 
             max_access_count: self.max_access_count,
             access_count: self.access_count,