-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inital support for user-selectable cursors #59
base: master
Are you sure you want to change the base?
Conversation
Thanks! Some notes-
|
That was intentional? I thought that just looked odd (especially as the text below it started not below it but on the left side). I prefer it the way it is now.
Depends on the compositor, wlroots / kwinft can do this, mutter can't. But because this is GTK, gtk just renders the titlebar as CSD on mutter. On the topic of making them "mandaritory", they should be well-supported because its csd; but I see why it isn't natural. - but they are settings afterall, its not that often that someone needs to change something. I'll change the key to tool_cursors and add it to the config. (Even tho the key should get added automatically with the fallback value when notekit tries to read the value and it isn't found. |
I'll look into merging this in a few days (I'm willing to give up my idiosyncratic preference on the checkboxes, but I do want to adjust it so at least the combo boxes for the Base Directory and the Pen Cursor are aligned - i.e. those labels should go into the size group), as right now cross-checking the flatpak support and attendant build system/dependency changes should probably take up all the bandwidth I can spare here. |
d86cbbf
to
f194cdf
Compare
You can now select the cursor notekit uses for a specific tool in the config. Key: root->tool->[text/pen/eraser/select]
And I've improved the Preferences, (the new things are just there graphically, so they are not yet working)