Add version check to reported output #164
Conversation
mosuem
requested review from
devmil,
adamgic,
fwagner,
fabiomcarneiro and
klink182
as code owners
| required PackageApiDiffResult diffResult, | ||
| required PackageApi oldPackageApi, | ||
| required PackageApi newPackageApi, | ||
| required bool ignorePrerelease, | ||
| required VersionCheckMode versionCheckMode, | ||
| }) { | ||
| stdout.writeln(''); | ||
| stdout.writeln('Checking Package version'); |
There was a problem hiding this comment.
I don't know what you want to still stdout here.
| oldVersion: oldVersion, | ||
| newVersion: newVersion, | ||
| neededVersion: null, | ||
| explanation: |
There was a problem hiding this comment.
Happy to change the explanations to anything you like better.
| @@ -40,126 +40,126 @@ void main() { | |||
|
|
|||
| group('Version Check', () { | |||
| test('is fine with breaking change and major version change', () { | |||
| bool versionChangeCheckResult = VersionCheck.versionChangeMatchesChanges( | |||
| final versionChangeCheckResult = VersionCheck.check( | |||
There was a problem hiding this comment.
The tests could be more fine-grained now probably, also checking for expected version etc.
|
Thanks for your changes @mosuem ! |
adds empty VersionCheckResult to console_diff_reporter_test
|
I allowed myself to adapt your PR a bit 😀 |
Thanks a lot! I was OOO :) |
Description
For our health.yaml workflow, it would be ideal if the version checking would also be part of the JSON report.
Type of Change