-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scijava to 30.0.0 #283
Conversation
Addresses #282 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it because @rgaiacs is not on the BoneJ2 refactoring team that his approval is not sufficient for merging?
Somehow he should get write access (don't think I can add him as I am a member, not an owner of the BoneJ Org)?
I assume this has been tested locally with mvn test -P allTests
, right? Just in case SciJava 30 breaks some API that we only use in the wrappers?
If so, happy with the changes too.
mvn clean test -P allTests
fails some AnisotropyWrapper tests for me
Assumuption is the mother of all eff-ups... need to fix these tests prior to merging. These failures are reminiscent of something we've dealt with before.
|
Failing tests in // in some method above
{
final String intensityPath ="8bit-signed&pixelType=int8&planarDims=2&lengths=5,5,3&axes=X,Y,Channel.fake";
mockIntensityFileOpening(intensityPath);
}
private void mockIntensityFileOpening(final String path) {
final File intensityFile = mock(File.class);
when(intensityFile.getAbsolutePath()).thenReturn(path);
when(MOCK_UI.chooseFile(any(File.class), anyString())).thenReturn(intensityFile);
} So it seems like a problem with the mocking of the broken file. |
The mocking appears to be broken in this version of scijava.
Also see #273 |
* Update scijava to 30.0.0 * Remove some tests that relied on mocking various file dimensions The mocking appears to be broken in this version of scijava.
No description provided.