Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent heartbeat timeout #701

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Prevent heartbeat timeout #701

merged 2 commits into from
Aug 30, 2023

Conversation

johnwlambert
Copy link
Collaborator

Dask will otherwise kill workers if they dont heartbeat for more than 30 mins.

Copy link
Contributor

@ayushbaid ayushbaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious we do it here instead of gtsfm runner

@akshay-krishnan
Copy link
Collaborator

I am curious we do it here instead of gtsfm runner

+1, could you move it to the runner? I think there are other dask config settings there too.

@johnwlambert
Copy link
Collaborator Author

@akshay-krishnan @ayushbaid I moved it to gtsfm/runner/gtsfm_runner_base.py now, thanks.

@johnwlambert johnwlambert merged commit 81a2671 into master Aug 30, 2023
24 checks passed
@johnwlambert johnwlambert deleted the prevent-heartbeat-timeout branch August 30, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants