-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metadata-sidebar): Handle create metadata isntance #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpiesiak
reviewed
Sep 18, 2024
wpiesiak
reviewed
Sep 18, 2024
wpiesiak
reviewed
Sep 18, 2024
wpiesiak
reviewed
Sep 18, 2024
wpiesiak
reviewed
Sep 18, 2024
wpiesiak
reviewed
Sep 18, 2024
src/elements/content-sidebar/hooks/useSidebarMetadataFetcher.ts
Outdated
Show resolved
Hide resolved
wpiesiak
reviewed
Sep 18, 2024
src/elements/content-sidebar/hooks/useSidebarMetadataFetcher.ts
Outdated
Show resolved
Hide resolved
wpiesiak
reviewed
Sep 18, 2024
greg-in-a-box
requested changes
Sep 18, 2024
src/elements/content-sidebar/__tests__/useSidebarMetadataFetcher.test.tsx
Outdated
Show resolved
Hide resolved
src/elements/content-sidebar/__tests__/useSidebarMetadataFetcher.test.tsx
Outdated
Show resolved
Hide resolved
src/elements/content-sidebar/__tests__/useSidebarMetadataFetcher.test.tsx
Outdated
Show resolved
Hide resolved
53b70ea
to
53c2819
Compare
JChan106
previously approved these changes
Sep 19, 2024
wpiesiak
reviewed
Sep 20, 2024
d88da16
to
c53ea8e
Compare
wpiesiak
reviewed
Sep 23, 2024
src/elements/content-sidebar/hooks/useSidebarMetadataFetcher.ts
Outdated
Show resolved
Hide resolved
wpiesiak
reviewed
Sep 23, 2024
wpiesiak
reviewed
Sep 23, 2024
d4f8107
to
3f8d6c7
Compare
wpiesiak
reviewed
Sep 24, 2024
wpiesiak
reviewed
Sep 24, 2024
wpiesiak
previously approved these changes
Sep 24, 2024
jankowiakdawid
previously approved these changes
Sep 24, 2024
e2a1f23
to
a51563d
Compare
greg-in-a-box
approved these changes
Sep 24, 2024
wpiesiak
approved these changes
Sep 24, 2024
JChan106
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
createMetadata
method to create a new instance from the chosen template.