fix(content-sidebar): add disabled state #3997
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjuanitas
previously approved these changes
Feb 28, 2025
| @@ -150,6 +150,7 @@ function BoxAISidebarContent(props: ApiWrapperWithInjectedProps) { | |||
| {isAIStudioAgentSelectorEnabled && ( | |||
| <div className="bcs-BoxAISidebar-agentSelector"> | |||
| <BoxAiAgentSelectorWithApi | |||
| disabled={props.hasRequestInProgress} | |||
There was a problem hiding this comment.
props is being destructured at the top so you could include hasRequestInProgress there
There was a problem hiding this comment.
Yes let's not pull this directly from props here. Let's add this to the list of destructured values coming from the props parameter at the top instead.
There was a problem hiding this comment.
no problem though I will need to add it to the Modal as it is also used there
bfoxx1906
reviewed
Mar 2, 2025
| @@ -150,6 +150,7 @@ function BoxAISidebarContent(props: ApiWrapperWithInjectedProps) { | |||
| {isAIStudioAgentSelectorEnabled && ( | |||
| <div className="bcs-BoxAISidebar-agentSelector"> | |||
| <BoxAiAgentSelectorWithApi | |||
| disabled={props.hasRequestInProgress} | |||
There was a problem hiding this comment.
Yes let's not pull this directly from props here. Let's add this to the list of destructured values coming from the props parameter at the top instead.
bfoxx1906
approved these changes
Mar 3, 2025
tjuanitas
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing disabled select agent when we ask AI a question similar solution that is in AI Modal