Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-sidebar): add disabled state #3997

Merged
merged 4 commits into from
Mar 3, 2025
Merged

fix(content-sidebar): add disabled state #3997

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95d720f
fix(content-sidebar): add disabled state
kmachulskiBox Feb 28, 2025
a577438
Merge branch 'master' into fixAISidebar
kmachulskiBox Feb 28, 2025
8cbaf8e
fix(content-sidebar): addressing review comments
kmachulskiBox Mar 3, 2025
ddd8df1
Merge branch 'master' into fixAISidebar
kmachulskiBox Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/elements/content-sidebar/BoxAISidebarContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ function BoxAISidebarContent(props: ApiWrapperWithInjectedProps) {
{isAIStudioAgentSelectorEnabled && (
<div className="bcs-BoxAISidebar-agentSelector">
<BoxAiAgentSelectorWithApi
disabled={props.hasRequestInProgress}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props is being destructured at the top so you could include hasRequestInProgress there

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's not pull this directly from props here. Let's add this to the list of destructured values coming from the props parameter at the top instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem though I will need to add it to the Modal as it is also used there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

fetcher={getAIStudioAgents}
hostAppName={hostAppName}
onAgentsListOpen={handleUserIntentToUseAI}
Expand Down