Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property to Hide Card Logos #426

Merged
merged 7 commits into from
Aug 10, 2023
Merged

Property to Hide Card Logos #426

merged 7 commits into from
Aug 10, 2023

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

Visuals

Without setCardLogosDisabled With setCardLogosDisabled
Screenshot_20230807_134500 Screenshot_20230807_134616

Checklist

  • Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner August 7, 2023 18:47
@jaxdesmarais jaxdesmarais mentioned this pull request Aug 7, 2023
Merged
1 task
@scannillo
Copy link
Contributor

Can we add a UI test that setting this property works as expected?

@jaxdesmarais
Copy link
Contributor Author

Can we add a UI test that setting this property works as expected?

Added both a UI and unit test: 3bcc715

@jaxdesmarais jaxdesmarais merged commit 225109a into master Aug 10, 2023
1 check passed
@jaxdesmarais jaxdesmarais deleted the property-to-hide-card-logos branch August 10, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@scannillo scannillo scannillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxdesmarais @scannillo @sshropshire