Property to Hide Card Logos #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
approved these changes
Aug 7, 2023
1 task
|
Same comment on Android PR re: adding a UI test |
Added: cce9007 |
jaxdesmarais
commented
Aug 9, 2023
| @@ -180,6 +180,61 @@ class BraintreeDropIn_CardDisabled_UITests: XCTestCase { | |||
| } | |||
| } | |||
|
|
|||
| class BraintreeDropIn_CardLogosDisabled_UITests: XCTestCase { | |||
There was a problem hiding this comment.
There is class for disabled and enabled because apparently the app.launchArguments need to be appended in setup instead of the test method. I guess that makes sense but would have been nice to have both tests in a single class, but that's not possible.
|
Unit tests failures are not related to this PR and are passing locally. We have ticket DTBTSDK-2886 to evaluate recent test failures in CI on the Drop-in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
BTDropInRequest.cardLogosDisabledto hide card logos on the credit card form if desiredVisuals
cardLogosDisabledcardLogosDisabledChecklist
Authors