-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real-time Sync: Add pull and merge #556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-yse
force-pushed
the
yse-rt-merge
branch
3 times, most recently
from
November 10, 2024 23:30
fa9dd75
to
8b6a409
Compare
roeierez
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure looks good and easy to review! There are some points we need to addres.
hydra-yse
force-pushed
the
yse-rt-persist
branch
from
November 11, 2024 23:59
c2fbcc1
to
9862dc4
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
November 12, 2024 00:01
8b6a409
to
9a43ba8
Compare
hydra-yse
force-pushed
the
yse-rt-persist
branch
from
November 12, 2024 00:54
9862dc4
to
cce9684
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
November 12, 2024 01:09
9a43ba8
to
ea5a5a6
Compare
roeierez
requested changes
Nov 12, 2024
roeierez
requested changes
Nov 12, 2024
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
November 13, 2024 01:35
ea5a5a6
to
9029a5d
Compare
hydra-yse
force-pushed
the
yse-rt-persist
branch
2 times, most recently
from
November 13, 2024 01:59
7c1cfbc
to
f422c7a
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
November 13, 2024 02:01
9029a5d
to
ee0a2ba
Compare
hydra-yse
force-pushed
the
yse-rt-persist
branch
2 times, most recently
from
November 13, 2024 02:25
84c7f96
to
0c56f34
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
3 times, most recently
from
November 13, 2024 03:23
2587800
to
9a63135
Compare
roeierez
requested changes
Nov 13, 2024
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
November 13, 2024 09:40
9a63135
to
37d6311
Compare
roeierez
requested changes
Nov 13, 2024
hydra-yse
force-pushed
the
yse-rt-persist
branch
2 times, most recently
from
November 14, 2024 18:26
25e3d8e
to
d4d28dd
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
November 20, 2024 22:38
c3a5d6e
to
29c1565
Compare
hydra-yse
force-pushed
the
yse-rt-persist
branch
from
November 20, 2024 22:38
eb0400b
to
be3091d
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
November 22, 2024 17:29
29c1565
to
8405996
Compare
This was referenced Nov 22, 2024
dangeross
reviewed
Nov 28, 2024
roeierez
requested changes
Nov 28, 2024
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
November 28, 2024 11:41
8405996
to
493b38d
Compare
hydra-yse
force-pushed
the
yse-rt-persist
branch
from
November 28, 2024 12:43
be3091d
to
b2b4b3a
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
November 28, 2024 12:43
493b38d
to
073d515
Compare
hydra-yse
force-pushed
the
yse-rt-persist
branch
from
November 28, 2024 15:01
b2b4b3a
to
fb8d13b
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
November 28, 2024 15:01
073d515
to
ce601d9
Compare
dangeross
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
December 5, 2024 01:35
ce601d9
to
764fae2
Compare
hydra-yse
added a commit
that referenced
this pull request
Dec 11, 2024
hydra-yse
added a commit
that referenced
this pull request
Dec 13, 2024
hydra-yse
added a commit
that referenced
this pull request
Dec 14, 2024
hydra-yse
added a commit
that referenced
this pull request
Dec 24, 2024
hydra-yse
added a commit
that referenced
this pull request
Dec 24, 2024
* feat(rt-sync): add persistency layer (#555) * feat(rt-sync): add pull and merge (#556) * feat(rt-sync): add push logic and run method (#568) * feat(rt-sync): integrate rt-sync with the sdk fix: add formatting command to build feat: add secondary trigger to sync deps: add tonic tls-webpki-roots feat: prevent double claiming on status stream handlers fix: add tx commit to chain swap update (#588) fix: ensure we pull records before prepare_send fix: fmt and tests * fix: set initial pulled state to `Recoverable` * feat(rt-sync): add `last_derivation_index` to sync service * Single chain source * Handle Recoverable state * fix(rt-sync): chain recovery integration (#590) Co-authored-by: yse <[email protected]> * feat(rt-sync): add `pair_fees_json` * fix(rt-sync): clean already persisted incoming records * feat: cache wallet info (#591) * log: add status-stream logging for non-local swaps * Sync improvements (#598) * Full sync on new Bitcoin block * Track the last unconfirmed refund tx * Trigger synced event on partial sync * fix: remove `REPLACE` clause from swap insert/update * fix(rt-sync): update chain swap payer/receiver amount (#604) * Fix syncing last derivation index * fix: update bindings and lockfile * remove logs * fix(rt-sync): avoid reuse of derivation index update logic (#608) * Add 5 index buffer to full scan * Fix storing claim_address (#609) * Filter incoming MRH txs by swap timestamp * fix liquid panding timestamp * persist tx data timestamp * Update unconfirmed transactions * feat: add API key (#618) * Use configured lazy connect channel in sync service * fix: set lower-case header (#624) * fix error message * Store & Sync LNURL info (#617) * Persist and decrypt LNURL info * Update Notification Plugin * Sync payment details * Update list payments to include chain swaps with only user lockup (#620) * Update payments query to include chain swaps without txs * Allow emitting a payment event without tx_id * fix: bindings --------- Co-authored-by: Ross Savage <[email protected]> Co-authored-by: Ross Savage <[email protected]> Co-authored-by: Roei Erez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #502, closes #503.
Based on #555.