Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-185213 #143663

Closed
wants to merge 11 commits into from
Closed

LPS-185213 #143663

wants to merge 11 commits into from

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-appsec#1465 (Took 1 ci:forward attempt in 46 minutes)
Console

@locpham97
@liferay-appsec

Original pull request comment:
Hi @alvarosaugarlr ,
Please help me review this PR.
This PR is the same as the previous PR liferay-appsec#1429. However, I made some changes in SimpleCaptchaImpl to fit AuthVerifierFilter in this commit liferay-appsec@e38afa1.
Many thanks,
Loc
cc: @tototrinh, @ces-quanhuynh

@liferay-continuous-integration
Copy link
Collaborator Author

✔️ ci:test:stable - 31 out of 31 jobs passed

❌ ci:test:relevant - 149 out of 206 jobs passed in 3 hours 27 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fadfdca50209a2a2e10f1845e1da5ec772ee682c

Upstream Comparison:

Branch GIT ID: fadfdca50209a2a2e10f1845e1da5ec772ee682c
Jenkins Build URL: EE Development Acceptance (master) - 135 - 2023-11-07[16:51:00]

ci:test:stable - 31 out of 31 jobs PASSED
31 Successful Jobs:
    ci:test:relevant - 149 out of 206 jobs PASSED

    57 Failed Jobs:

    149 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      Failures in common with acceptance upstream results at fadfdca:
      3. ...

      @liferay-continuous-integration
      Copy link
      Collaborator Author

      ✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: 0119cc0975fcd6f5461709d2d2f47dbcbdef0e20

      Sender Branch:

      Branch Name: LPS-185213-impl
      Branch GIT ID: 116255a96b00f3091158885cc1041054a8c98880

      1 out of 1jobs PASSED
      1 Successful Jobs:
      For more details click here.

      @liferay-continuous-integration
      Copy link
      Collaborator Author

      To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

      Closed
      @brianchandotcom
      Copy link
      Owner

      I sent this PR to stian-sigvartsen#295

      The problem with this PR is that the code just doesn't feel very Liferayee (standard conventions). @stian-sigvartsen please resend this back to me in smaller chunks. For example, the REST api just looks off (doesn't match our other REST api).

      @locpham97 @ces-quanhuynh fyi

      @brianchandotcom brianchandotcom mentioned this pull request Nov 18, 2023
      Open
      @stian-sigvartsen stian-sigvartsen mentioned this pull request Nov 23, 2023
      Closed
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers
      No reviews
      Assignees
      No one assigned
      Labels
      None yet
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      5 participants
      @liferay-continuous-integration @brianchandotcom @ces-locpham @ces-quanhuynh @alvarosaugarlr