forked from liferay/liferay-portal
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-185213 #295
Open
brianchandotcom
wants to merge
8,543
commits into
stian-sigvartsen:master
Choose a base branch
from
brianchandotcom:pull-request-143663-LPS-185213
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LPS-185213 #295
brianchandotcom
wants to merge
8,543
commits into
stian-sigvartsen:master
from
brianchandotcom:pull-request-143663-LPS-185213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
producers configuration because it can produce offensive words
…pon close, to avoid "pending finailization" keeps memory footprint large.
…s AssetSearcherFactoryUtil
…: Add validation when liferay is not clustered, limit to 1 config https://liferay.atlassian.net/browse/LPS-201176
…hods always return true.
…l no longer be part of the default schema.
* Control tables are removed from the standalone partition schema. * Views are created in the partition schema as part of integrating the partition in a new default schema.
…based on the companyId, so it is needed to retrieve the correct schema.
… existing companyIds since companyId can not collide. We can skip it since the Unique Index in Company will provide an error with better explanation
…since they can vary
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
@stian-sigvartsen see my comments in brianchandotcom#143663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.