Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lk pd 2736 doublets #1362

Merged
merged 38 commits into from
Oct 2, 2024
Merged

Lk pd 2736 doublets #1362

merged 38 commits into from
Oct 2, 2024

Conversation

ekiernan
Copy link
Contributor

@ekiernan ekiernan commented Aug 20, 2024

This PR adds new dockers for warp-tools and for merge-star-npz in order to accomodate new calculations for doublet scores.

The warp-tools docker has been modified to include a new script for calculating doublet scores using a modified DoubletFinder from the Allen Institute.

It then uses this script to calculate new library-level metrics such as percent doublets and new keeper cell metrics.

The merge-npz-docker has been modified with a new combined_matrix.py script that removes the calculation of the keeper cell metrics so that it can be calculated after doublet scores.

The Optimus WDL no longer calculates keeper metrics in the mergestaroutputs task, but instead does this calculation during h5ad production using h5adUtils.wdl.

This PR also updates documentation.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
Multiome.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
Multiome.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
Multiome.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
Multiome.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
Multiome.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
Multiome.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
Multiome.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@ekiernan
Copy link
Contributor Author

Smart-test failures are as expected. We added two new columns to the h5ad. Gene metric comparisons fail because we've made gene_names unique now. When we make truth gene_names unique the metrics match.

@ekiernan
Copy link
Contributor Author

retest this please

Copy link
Member

@jessicaway jessicaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @ekiernan !

@ekiernan
Copy link
Contributor Author

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

github-actions bot commented Oct 2, 2024

Remember to squash merge!

Copy link

github-actions bot commented Oct 2, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

github-actions bot commented Oct 2, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@ekiernan
Copy link
Contributor Author

ekiernan commented Oct 2, 2024

The only smart-test that failed was scATAC - which ran because we modified the VerifyTasks.

@ekiernan ekiernan merged commit 30e4994 into develop Oct 2, 2024
11 of 12 checks passed
@ekiernan ekiernan deleted the lk-PD-2736-doublets branch October 30, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants