-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lk pd 2736 doublets #1362
Lk pd 2736 doublets #1362
Conversation
Remember to squash merge! |
🔍Changelog Validation Results:
|
🔍Version Validation Results:
|
Remember to squash merge! |
🔍Changelog Validation Results:
|
🔍Version Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Changelog Validation Results:
|
🔍Version Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Changelog Validation Results:
|
🔍Version Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Smart-test failures are as expected. We added two new columns to the h5ad. Gene metric comparisons fail because we've made gene_names unique now. When we make truth gene_names unique the metrics match. |
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @ekiernan !
First run of smart-tests here: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-smart-tests/8500/ |
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
The only smart-test that failed was scATAC - which ran because we modified the VerifyTasks. |
This PR adds new dockers for warp-tools and for merge-star-npz in order to accomodate new calculations for doublet scores.
The warp-tools docker has been modified to include a new script for calculating doublet scores using a modified DoubletFinder from the Allen Institute.
It then uses this script to calculate new library-level metrics such as percent doublets and new keeper cell metrics.
The merge-npz-docker has been modified with a new combined_matrix.py script that removes the calculation of the keeper cell metrics so that it can be calculated after doublet scores.
The Optimus WDL no longer calculates keeper metrics in the mergestaroutputs task, but instead does this calculation during h5ad production using h5adUtils.wdl.
This PR also updates documentation.