ref: Split eslint and prettier #335
Conversation
|
I need to update the documentation before I merge this in! |
|
Visit the preview URL for this PR (updated for commit 5238ddf): https://ccv-honeycomb--pr335-ref-eslint-prettier-owld1nwa.web.app (expires Wed, 29 Nov 2023 15:49:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
RobertGemmaJr
requested review from
broarr,
digicosmos86 and
anna-murphy
and removed request for
digicosmos86,
fordmcdonald and
hetd54
|
Coincides with this PR in the documentation |
| /.pnp | ||
| .pnp.js |
There was a problem hiding this comment.
No, just npm. But it's been the gitignore since I started on the project 🤷♂️
| @@ -20,8 +20,8 @@ let USE_EEG = false; | |||
| let VIDEO = false; | |||
|
|
|||
| // Override product ID if environment variable set | |||
| const activeProductId = process.env.EVENT_MARKER_PRODUCT_ID || productId; | |||
| const activeComName = process.env.EVENT_MARKER_COM_NAME || comName; | |||
| const activeProductId = process.env.EVENT_MARKER_PRODUCT_ID ?? productId; | |||
There was a problem hiding this comment.
Was this a linting fix, or was it manually changed? I don't see a corresponding rule, but it might be a good idea to rule this in the linter if possible.
There was a problem hiding this comment.
It was a manual change. It's something I've been eyeing and can now change since I've updated the ecma version
Cleans up our eslint file, including removing prettier from it. The
formatscript will be updated to run prettier directly (#336)jestto env??operator instead of||where it's more appropriate (can no do because of the bump to ecma)