-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Split eslint and prettier #335
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
73c783e
chore: Cleanup eslintignore
RobertGemmaJr a896856
chore: Update prettierrc
RobertGemmaJr 87814d3
wip: Begin linting test files
RobertGemmaJr c2f3bd6
wip: Remove overrides from the eslint config
RobertGemmaJr 0af698c
wip: Remove uneeded keys form eslint file
RobertGemmaJr 4deb549
wip: Update ecmaVersion to 2023
RobertGemmaJr 19a9c79
wip: Remove unused globals from the eslint file
RobertGemmaJr cbe1ca6
chore: remove commented out code
RobertGemmaJr 66c265b
wip: Remove unused rules section
RobertGemmaJr 1c0df26
chore: Remove commented out code
RobertGemmaJr 51af2a5
chore: Add rule back
RobertGemmaJr 5238ddf
chore: comments
RobertGemmaJr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,28 @@ | ||
module.exports = { | ||
root: true, | ||
env: { | ||
browser: true, | ||
es6: true, | ||
jest: true, | ||
node: true, | ||
}, | ||
extends: [ | ||
"eslint:recommended", | ||
"plugin:react/recommended", | ||
// TODO 325: Add rules for import order | ||
"prettier", | ||
], | ||
parserOptions: { | ||
ecmaFeatures: { | ||
jsx: true, | ||
}, | ||
ecmaVersion: 2018, | ||
sourceType: "module", | ||
ecmaVersion: 2023, | ||
}, | ||
plugins: ["react"], | ||
rules: { | ||
"react/prop-types": "off", // TODO: These should be added so the rule can be removed | ||
}, | ||
settings: { | ||
react: { | ||
version: "detect", | ||
}, | ||
}, | ||
env: { | ||
browser: true, | ||
node: true, | ||
es6: true, | ||
}, | ||
globals: { | ||
Atomics: "readonly", | ||
SharedArrayBuffer: "readonly", | ||
}, | ||
plugins: ["react", "prettier"], | ||
extends: ["eslint:recommended", "plugin:react/recommended", "prettier"], | ||
rules: { | ||
"react/prop-types": "off", | ||
"prettier/prettier": "warn", | ||
}, | ||
overrides: [{ files: ["*.jsx", "*.js"] }], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,16 @@ | ||
/** | ||
* This file defines specific rules for Prettier. It adjusts their default settings. | ||
* The CCV recommends these settings if your lab does not have specific style standards. | ||
* We recommend these settings if your lab does not have specific style standards. | ||
*/ | ||
module.exports = { | ||
trailingComma: "es5", // Add a trailing comma to all es5 modules | ||
printWidth: 100, // Sets the maximum line size to 100 (default is 80) | ||
endOfLine: "auto", // Configure the end of line character (/n) | REQUIRED FOR OS COMPATIBILITY | ||
quoteProps: "as-needed", // Add quotes around props as needed | ||
trailingComma: "es5", // Add a trailing comma to all es5 modules | ||
overrides: [ | ||
{ | ||
// Treats .firebaserc as a json file | ||
files: ".firebaserc", | ||
options: { parser: "json" }, | ||
}, | ||
], | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're using modern yarn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, just
npm
. But it's been the gitignore since I started on the project 🤷♂️