Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #185: Added a Favicon #188

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Fix #185: Added a Favicon #188

merged 3 commits into from
Jun 10, 2024

Conversation

yashpatil641
Copy link
Contributor

@yashpatil641 yashpatil641 commented Jun 9, 2024

Overview

  1. This PR fixes or fixes part of [Feature Request]: Add favicon for Getit #185.
  2. This PR does the following: Adds a favicon

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

image

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for merch-site ready!

Name Link
🔨 Latest commit b0998ba
🔍 Latest deploy log https://app.netlify.com/sites/merch-site/deploys/6666cda29332730008bf8b31
😎 Deploy Preview https://deploy-preview-188--merch-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@AkashPaloju AkashPaloju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a pass , PTAL

backend/build.py Outdated Show resolved Hide resolved
@@ -1,4 +1,8 @@
<template>

<title>GetIt</title>
<link rel="icon" type="image/png" href="\Favicon.svg">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the image file to favicon.svg, change it here also.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashpatil641 You haven't addressed this completely!!

package-lock.json Outdated Show resolved Hide resolved
@yashpatil641
Copy link
Contributor Author

@AkashPaloju i have made the necessary changes

@AkashPaloju
Copy link
Collaborator

AkashPaloju commented Jun 10, 2024

@yashpatil641 please update the screnshot in the PR description after the changes

@yashpatil641
Copy link
Contributor Author

@yashpatil641 please update the screnshot in the PR description after the changes

done

@AkashPaloju
Copy link
Collaborator

Thanks for the PR @yashpatil641

@Kushdapush Kushdapush merged commit cabc840 into bsoc-bitbyte:main Jun 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add favicon for Getit
3 participants