-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #185: Added a Favicon #188
Conversation
✅ Deploy Preview for merch-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took a pass , PTAL
frontend/pages/index.vue
Outdated
@@ -1,4 +1,8 @@ | |||
<template> | |||
|
|||
<title>GetIt</title> | |||
<link rel="icon" type="image/png" href="\Favicon.svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename the image file to favicon.svg, change it here also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashpatil641 You haven't addressed this completely!!
@AkashPaloju i have made the necessary changes |
@yashpatil641 please update the screnshot in the PR description after the changes |
done |
Thanks for the PR @yashpatil641 |
Overview
Essential Checklist
Proof that changes are correct
PR Pointers