fix CI #25
Merged
fix CI #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guy Bedford <[email protected]>
Signed-off-by: Guy Bedford <[email protected]>
Signed-off-by: Guy Bedford <[email protected]>
Signed-off-by: Guy Bedford <[email protected]>
Signed-off-by: Guy Bedford <[email protected]>
Signed-off-by: Guy Bedford <[email protected]>
Signed-off-by: Guy Bedford <[email protected]>
Signed-off-by: Guy Bedford <[email protected]>
Signed-off-by: Guy Bedford <[email protected]>
Merged
|
These tools are all installed by the cmake script as well, so it'd be great if we could use those versions instead of building them from source for every run. Perhaps a good way to enable this would be to introduce a CMake target that prints a |
|
Okay done, it seems like GitHub actions doesn't like altering the PATH for some reason, so I've used explicit WIZER and WASM_TOOLS env vars in the componentize script. |
tschneidereit
approved these changes
Apr 17, 2024
.github/workflows/main.yml
Outdated
Comment on lines
25
to
27
| wasmtime: [19.0.2] | ||
| wizer: [5.0.0] | ||
| wasm-tools: [1.203.0] |
There was a problem hiding this comment.
Is this change still needed?
There was a problem hiding this comment.
Good catch, thanks.
Signed-off-by: Guy Bedford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the Wasmtime install, which I believe is due to the Rust toolchain lock to version
1.68.3. In addition adds Wizer and wasm-tools installs.