New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Populate the map with project markers #13

Merged

ethan-tam33 merged 6 commits into main from 7-feat-populate-the-map-with-project-markers

Oct 18, 2024

Collaborator

ethan-tam33 commented Oct 13, 2024 •

edited

Loading

What's new in this PR

Description

added markers to google map by creating addMarker.tsx dependent on approval status
added Project type object

Screenshots

How to review

review the app/page.tsx file
review the api/maps/addMarkers.tsx file
review the types/helper.d.ts file
load the home screen to see that all the markers with approval render properly (ensure that you have the API key in .env.local)

Next steps

Relevant links

Online sources

Related PRs

CC: @itsliterallymonique

ethan-tam33 added 2 commits

October 13, 2024 03:43


          marker working

c4e3989


          [feat] added marker

978e4bb

ethan-tam33 linked an issue

that may be closed by this pull request

[feat] Populate the Map with Project Markers #7

Closed

ethan-tam33 requested review from itsliterallymonique and jjstnlee

October 14, 2024 01:00


          shifted center and removed debug

itsliterallymonique approved these changes

View reviewed changes

Collaborator

itsliterallymonique left a comment

beautiful work! approved

Collaborator

itsliterallymonique commented Oct 14, 2024

@ethan-tam33 Make sure you don't overwrite Julee's schema changes when you squash and merge! Thanks!

jjstnlee reviewed

View reviewed changes

api/maps/addMarker.tsx Outdated Show resolved Hide resolved

jjstnlee reviewed

View reviewed changes

types/helper.d.ts Outdated Show resolved Hide resolved

jjstnlee reviewed

View reviewed changes

components/Map/map.tsx Outdated Show resolved Hide resolved

jjstnlee reviewed

View reviewed changes

app/testing/page.tsx Outdated Show resolved Hide resolved

jjstnlee reviewed

View reviewed changes

app/page.tsx Outdated Show resolved Hide resolved

jjstnlee reviewed

View reviewed changes

api/maps/addMarker.tsx Outdated Show resolved Hide resolved

jjstnlee requested changes

View reviewed changes

Collaborator

jjstnlee left a comment

great job ethan!!! i wrote some comments so just take a look at those when you can and also if i am wrong abt something pls lmk i am not a genius :(

ethan-tam33 added 3 commits

October 17, 2024 00:49


          removed index

3d9fb04


          [fix] use Project schema

4d81489


          [fix] use Project schema

1bb8b6c

Collaborator Author

ethan-tam33 commented Oct 17, 2024

Thank you Monique and Justin! Just fixed all the issues mentioned above in the most recent push.

ethan-tam33 requested a review from jjstnlee

October 17, 2024 08:05

Collaborator

itsliterallymonique commented Oct 17, 2024

Thank you Monique and Justin! Just fixed all the issues mentioned above in the most recent push.

@ethan-tam33 thanks. you can squash + merge to main now

jjstnlee approved these changes

View reviewed changes

Collaborator

jjstnlee left a comment

awesome sauce

ethan-tam33 merged commit 82a0112 into main

2 checks passed

ethan-tam33 deleted the 7-feat-populate-the-map-with-project-markers branch

October 18, 2024 03:47

itsliterallymonique mentioned this pull request

[feat] Custom Markers based on Renewable Energy Technology #47

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet