Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the *.xcodeproj from ios template #470

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

satya164
Copy link
Member

Summary

This removes the *.xcodeproj from the ios directory in the generated library. These files are not needed for autolinking, and keeping them has few downsides:

  • People open this project instead of example and it doesn't work, so it adds confusion
  • It's a big unreadable file to maintain, both for library developers and for us

Test plan

Generate a project without the *.xcodeproj and verify that it compiles and runs

@satya164 satya164 merged commit 08a3230 into main Sep 29, 2023
6 of 32 checks passed
@satya164 satya164 deleted the @satya164/remove-xcodeproj branch September 29, 2023 11:14
@YOEL311
Copy link

YOEL311 commented Dec 31, 2023

Hey @satya164
I need to create a module that uses with local library .framework
how i can link the .framework files without the xcodeproj file?

@gausam
Copy link

gausam commented Feb 27, 2024

@satya164 could this perhaps return as an optional flag during install? I've also run into the same need as @YOEL311's.

@satya164
Copy link
Member Author

@gausam dependencies in react native libraries are managed with cocoapods, not with xcodeproj file. you need to include your framework using cocoapods #379

kirillzyusko added a commit to kirillzyusko/react-native-keyboard-controller that referenced this pull request Apr 14, 2024
## 📜 Description

Removed `*.xcodeproj` and all associated files.

## 💡 Motivation and Context

It seems like this file is not needed anymore as all linking is done via
cocoapods. So in this PR I'm removing it because:
- it should reduce npm package on ~19kb;
- we will not need to synchronize it with fs anymore;
- it's not used file.

Similar changes were made in
callstack/react-native-builder-bob#470

<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->

## 📢 Changelog

<!-- High level overview of important changes -->
<!-- For example: fixed status bar manipulation; added new types
declarations; -->
<!-- If your changes don't affect one of platform/language below - then
remove this platform/language -->

### iOS

- removed `xcodeproj` associated files;

## 🤔 How Has This Been Tested?

Tested on CI.

## 📝 Checklist

- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants