feat!: add ability to use react-native-test-app for example/ app
#572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
commented
Jun 27, 2024
packages/create-react-native-library/src/utils/generateExampleApp.ts
Outdated
Show resolved
Hide resolved
szymonrybczak
commented
Jun 27, 2024
packages/create-react-native-library/src/utils/generateExampleApp.ts
Outdated
Show resolved
Hide resolved
szymonrybczak
changed the title
react-native-test-app in example/ appreact-native-test-app for example/ app
satya164
requested changes
Jun 27, 2024
packages/create-react-native-library/templates/example-legacy/example/react-native.config.js
Outdated
Show resolved
Hide resolved
...s/create-react-native-library/templates/native-common-example/example/react-native.config.js
Outdated
Show resolved
Hide resolved
satya164
reviewed
Jul 1, 2024
satya164
force-pushed
the
szymonrybczak/feat-add-rnta
branch
from
4a906ef to
9d290d2
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary In #572 we've introduced `test-app` as an option for `example` project, and CRNL contains two scripts `build:ios` and `build:android` that are injected when creating project, RNTA also contains two scripts named in the same way, which are then replaced - in this Pull Request in relevant scenario I added logic which joins two scripts. ### Test plan 1. Create a new project with `create-react-native-library` 2. Choose `test-app` for `example/` 3. `build:ios` and `build:android` should contain logic of creating and bundling app as well as building app with relevant options.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary A regression introduced in #572. CRNL shouldn't ask for example type in local library scenario. ### Test plan 1. Run `create-react-native-library` under a React Native project. 2. Example project shouldn't be included in the local library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
react-native-test-appforexmaple/app. RNTA was created to help library maintainers focus on building library by providing seamless React Native versions switching, first-class support for OOT platforms and a lot more!Test plan
Generated app should work in the same way as before (created library should be automatically linked).