Partially revert #52 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add back functional test for bionic and juju 2.9
chanchiwai-ray
force-pushed
the
issue/67/SOLENG-849
branch
from
fffa8b3 to
2df2972
Compare
Workaround for juju/python-libjuju#1184 in older libjuju 2.x releases.
chanchiwai-ray
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza,
rgildein and
Deezzir
samuelallan72
approved these changes
Nov 19, 2024
jneo8
approved these changes
Nov 19, 2024
chanchiwai-ray
added a commit
that referenced
this pull request
Nov 22, 2024
samuelallan72
pushed a commit
that referenced
this pull request
Dec 2, 2024
* update .github/workflows/release.yaml * update .github/workflows/promote.yaml * update .github/workflows/check.yaml * update .github/workflows/release.yaml * update .github/workflows/promote.yaml * update .github/workflows/check.yaml * update .github/workflows/promote.yaml * update .github/workflows/release.yaml * update .github/workflows/check.yaml * Copy from automation repo * Remove unused sonarqube workflow * Refactor workflow to fit automation repo. * typo * typo * Remove file name * Add bionic in gate bundles (regression from #68) * More typo * Support nested containers in LXD * Workaround for installing on bionic * try this * Ignore type since it's not going to be compatible with python3.8 and 3.10 * Change to Any type * Fix more thinko --------- Co-authored-by: soleng-terraform[bot] <168111096+soleng-terraform[bot]@users.noreply.github.com> Co-authored-by: Chi Wai Chan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
websockets14.0 breaks python-libjuju juju/python-libjuju#1184 in older libjuju release (e.g. 2.x)closes: #67