-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-3737] Add a zookeeper_client interface #144
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nitpicks and a couple suggestions! I haven't had a chance to go through with a fine-comb yet, but will do when the PR is open.
Overall it looks good! I haven't seen the Pydantic use for client-relation-interfaces yet, and I'm less familiar with what actually is expected for secret-relations, so I'll defer my opinions to those more in the know.
Oh, and I suggest you just open a branch in the repo, rather than using forks. Makes it easier whenever other people from the team want to make changes to a PR branch!
Thanks for the review!
Unfortunately I don't have permission :( |
This reverts commit a2fffdd.
e954e85
to
9b7d5e2
Compare
Still need to remove 'branch' upon upstream merge
854b72f
to
c92ca8e
Compare
2da65f9
to
354fac0
Compare
A leftover from some testing
Hey there @gruyaume, I updated this PR with the new |
This PR adds a
zookeeper
interface.Notes:
zookeeper
instead ofzookeeper_client
to keep compatibility with existing charmsUPDATE: Turns out the tester design is not compatible with the way our charms update the relation databag (=not as a result of "zookeeper-relation-changed")