-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-3737] Implement ZK client interface #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I have understood why the renaming of the endpoint
is needed. I'm a bit afraid that it may creates problems when upgrading (if we have existing relations already)
have we tested that it works fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat. I liked the deprecation implementation, TIL as well :)
* feat: Backport VM charm changes From canonical/zookeeper-operator#142 * fix: Maybe fix conflicting nodes error? * fix: Fix attr access in quorum manager * chore: Fix type lint issues * feat: Backport changes from VM charm
The following changes were made to the interface:
chroot
bydatabase
chroot-acl
byextra-user-roles
uris
byendpoints
*well, not exactly "replaced", we kept the old fields around for backward compatibility.
There are a few issues with the
charm-relation-interfaces
repository:interface_tester