fix(alert): Ignore ipmi Entity Presence type alert #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alert rule ipmi_generic_sensor_value ignoe type="Entity Presence"
aieri
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Some minor rewording. Also please add context to this change and the related bug. Why are we doing this? Is this related to https://bugs.launchpad.net/charm-hw-health/+bug/1891915 ?
Pjack
approved these changes
Nov 15, 2023
It's a different case that want to ignore Entity Absent. I would like to put it into another issue. |
|
Hi @aieri , I update the wording and put some information on the issue. |
aieri
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alert rule ipmi_generic_sensor_value ignoe type="Entity Presence"
Fix: #102