Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #147 #148

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Fix: #147 #148

merged 3 commits into from
Jan 15, 2024

Conversation

honghan-wong
Copy link
Contributor

Fix: #147

@honghan-wong honghan-wong marked this pull request as ready for review January 9, 2024 01:44
@honghan-wong honghan-wong requested review from a team, Pjack, aieri, agileshaw, jneo8 and rgildein January 9, 2024 01:44
sudeephb
sudeephb suggested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@sudeephb sudeephb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change.
Rather than making an exception for ipmiselcollector, we could change the alert rule to for: 1m for all the collectors. If a collector is really down, it will be down for > 1m anyway.

Do you have any second opinion @jneo8 / @Pjack ?

dashmage
dashmage suggested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@dashmage dashmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I've left a few comments 😄

src/prometheus_alert_rules/general.yaml Outdated Show resolved Hide resolved
src/prometheus_alert_rules/general.yaml Outdated Show resolved Hide resolved
tests/unit/test_alert_rules/test_general.yaml Outdated Show resolved Hide resolved
sudeephb
sudeephb approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@sudeephb sudeephb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dashmage
dashmage approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@dashmage dashmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks for making the suggested changes!

@Pjack Pjack merged commit b61b1c2 into canonical:master Jan 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudeephb sudeephb sudeephb approved these changes

@dashmage dashmage dashmage approved these changes

@Pjack Pjack Pjack approved these changes

@aieri aieri Awaiting requested review from aieri

@agileshaw agileshaw Awaiting requested review from agileshaw

@jneo8 jneo8 Awaiting requested review from jneo8

@rgildein rgildein Awaiting requested review from rgildein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

General collector fail alerts too frequent
4 participants
@honghan-wong @Pjack @dashmage @sudeephb