Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #147 #148

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Fix: #147 #148

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6d75be
Fix: #147
honghan-wong Jan 8, 2024
ee6a4dd
update to 1m eval time
honghan-wong Jan 10, 2024
ad362c8
fix unit test eval time
honghan-wong Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/prometheus_alert_rules/general.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ groups:
- name: HardwareObserver
rules:
- alert: CollectorFailed
expr: '{__name__=~"(.*)_collector_failed"} == 1'
expr: '{__name__=~"(.*)_collector_failed",__name__!="ipmiselcollector_collector_failed"} == 1'
honghan-wong marked this conversation as resolved.
Show resolved Hide resolved
for: 0m
labels:
severity: error
Expand All @@ -11,3 +11,13 @@ groups:
description: |
A collector failed to fetch the metrics. Please reach out to hardware-observer maintainers.
LABELS = {{ $labels }}
- alert: IpmiSelCollectorFailed
expr: '{__name__="ipmiselcollector_collector_failed"} == 1'
for: 1m
labels:
severity: error
annotations:
summary: Ipmi Sel Collector failed. (instance {{ $labels.instance }})
description: |
Ipmi sel collector failed to fetch the metrics. Please reach out to hardware-observer maintainers.
LABELS = {{ $labels }}
dashmage marked this conversation as resolved.
Show resolved Hide resolved
14 changes: 14 additions & 0 deletions tests/unit/test_alert_rules/test_general.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ tests:
values: '1x15'
- series: ipmisel_collector_failed{instance="ubuntu-99", collector="ipmisel"}
values: '1x15'
- series: ipmiselcollector_collector_failed{instance="ubuntu-99", collector="IpmiSelCollector"}
values: '1x15'
honghan-wong marked this conversation as resolved.
Show resolved Hide resolved

alert_rule_test:
- eval_time: 0m
Expand All @@ -33,3 +35,15 @@ tests:
description: |
A collector failed to fetch the metrics. Please reach out to hardware-observer maintainers.
LABELS = map[__name__:ipmisel_collector_failed collector:ipmisel instance:ubuntu-99]
- eval_time: 1m
alertname: IpmiSelCollectorFailed
exp_alerts:
- exp_labels:
severity: error
instance: ubuntu-99
collector: IpmiSelCollector
exp_annotations:
summary: Ipmi Sel Collector failed. (instance ubuntu-99)
description: |
Ipmi sel collector failed to fetch the metrics. Please reach out to hardware-observer maintainers.
LABELS = map[__name__:ipmiselcollector_collector_failed collector:IpmiSelCollector instance:ubuntu-99]