Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noble integration tests #342

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Add noble integration tests #342

merged 4 commits into from
Nov 19, 2024

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Nov 14, 2024

The hw supports Noble, but we did not provide tests for it.

fixes: #339

@rgildein rgildein self-assigned this Nov 14, 2024
@rgildein rgildein force-pushed the chore/no-ref/add-noble-ci branch 2 times, most recently from 892ed68 to 9590bf6 Compare November 14, 2024 17:36
@Deezzir
Copy link
Contributor

Deezzir commented Nov 14, 2024

Do we need anything else to support noble testing?

@rgildein rgildein force-pushed the chore/no-ref/add-noble-ci branch 2 times, most recently from 65c72a8 to aee0df5 Compare November 15, 2024 12:34
The hw supports Noble, but we did not provide tests for it.
Add noble option to pytest CLI options.

Signed-off-by: Robert Gildein <[email protected]>
@rgildein rgildein force-pushed the chore/no-ref/add-noble-ci branch from aee0df5 to 2d02582 Compare November 15, 2024 12:37
Grafana-agent do not support arm64 for Noble.

Signed-off-by: Robert Gildein <[email protected]>
Deezzir
Deezzir previously approved these changes Nov 15, 2024
Copy link
Contributor

@Deezzir Deezzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we must not forget to change the channel for grafana-agent when it comes to stable

.github/workflows/check.yaml Outdated Show resolved Hide resolved
tests/functional/bundle.yaml.j2 Outdated Show resolved Hide resolved
Copy link
Contributor

@Deezzir Deezzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgildein rgildein merged commit d56ff3c into main Nov 19, 2024
10 checks passed
@rgildein rgildein deleted the chore/no-ref/add-noble-ci branch November 19, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run functional tests on Noble
4 participants