-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add noble integration tests #342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgildein
force-pushed
the
chore/no-ref/add-noble-ci
branch
2 times, most recently
from
November 14, 2024 17:36
892ed68
to
9590bf6
Compare
Do we need anything else to support noble testing? |
rgildein
force-pushed
the
chore/no-ref/add-noble-ci
branch
2 times, most recently
from
November 15, 2024 12:34
65c72a8
to
aee0df5
Compare
The hw supports Noble, but we did not provide tests for it. Add noble option to pytest CLI options. Signed-off-by: Robert Gildein <[email protected]>
rgildein
force-pushed
the
chore/no-ref/add-noble-ci
branch
from
November 15, 2024 12:37
aee0df5
to
2d02582
Compare
Grafana-agent do not support arm64 for Noble. Signed-off-by: Robert Gildein <[email protected]>
rgildein
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza,
Deezzir and
chanchiwai-ray
November 15, 2024 13:54
Deezzir
previously approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we must not forget to change the channel for grafana-agent when it comes to stable
aieri
approved these changes
Nov 18, 2024
aieri
requested changes
Nov 18, 2024
Co-authored-by: Andrea Ieri <[email protected]>
Deezzir
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aieri
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hw supports Noble, but we did not provide tests for it.
fixes: #339