Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network bridges #3195

Merged
merged 54 commits into from
Jan 5, 2024

[daemon] Filter out empty MAC addresses.

89f1b78
Select commit
Loading
Failed to load commit list.
Merged

Add network bridges #3195

[daemon] Filter out empty MAC addresses.
89f1b78
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 4, 2024 in 0s

84.05% (+0.13%) compared to 4b38e63

View this Pull Request on Codecov

84.05% (+0.13%) compared to 4b38e63

Details

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (4b38e63) 83.92% compared to head (89f1b78) 84.05%.

Files Patch % Lines
src/daemon/daemon.cpp 94.25% 5 Missing ⚠️
src/client/cli/cmd/launch.cpp 0.00% 4 Missing ⚠️
src/client/cli/cmd/delete.cpp 0.00% 3 Missing ⚠️
src/daemon/instance_settings_handler.cpp 89.65% 3 Missing ⚠️
...rc/platform/backends/qemu/qemu_virtual_machine.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3195      +/-   ##
==========================================
+ Coverage   83.92%   84.05%   +0.13%     
==========================================
  Files         251      251              
  Lines       13678    13793     +115     
==========================================
+ Hits        11479    11594     +115     
  Misses       2199     2199

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov