Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create single-nic-vm-host-with-vlans.md #476

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Create single-nic-vm-host-with-vlans.md #476

merged 3 commits into from
Jun 19, 2024
+240 −0

Conversation

ilvipero
Copy link
Contributor

Description

This how to covers the scenario of a virtual machine host based on Ubuntu with a single NIC and three VLANs, and walks users through the required configuration steps using netplan and virsh.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@slyon slyon requested a review from rkratky May 29, 2024 09:28
@slyon slyon added documentation Documentation improvements. community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. labels May 29, 2024
slyon
slyon reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments from my side, but let's wait for Robert's feedback as well.

doc/single-nic-vm-host-with-vlans.md Outdated Show resolved Hide resolved
doc/single-nic-vm-host-with-vlans.md Outdated Show resolved Hide resolved
doc/single-nic-vm-host-with-vlans.md Outdated Show resolved Hide resolved
doc/single-nic-vm-host-with-vlans.md Outdated Show resolved Hide resolved
doc/single-nic-vm-host-with-vlans.md Outdated Show resolved Hide resolved
@slyon slyon added the Canonical by Canonical employees outside the Netplan team label Jun 5, 2024
@slyon
Copy link
Collaborator

slyon commented Jun 19, 2024

FTR: Some fixes landed via ilvipero#2

ilvipero and others added 3 commits June 19, 2024 12:14
@ilvipero @slyon
Create single-nic-vm-host-with-vlans.md
c91da14 
This how to covers the scenario of a  virtual machine host based on Ubuntu with a single NIC and three VLANs, and walks users through the required configuration steps using netplan and virsh.
@ilvipero @slyon
Apply suggestions from code review
f551bdf 
Co-authored-by: Lukas Märdian <[email protected]>
@rkratky @slyon
Reformat single-nic-vm-host-with-vlans.
f2b90d4
slyon
slyon approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the most recent fixes, thanks!
I also rebased on top of #475

@slyon slyon merged commit 330e5a8 into canonical:main Jun 19, 2024
4 of 5 checks passed
@slyon slyon mentioned this pull request Jun 19, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slyon slyon slyon approved these changes

@rkratky rkratky Awaiting requested review from rkratky

Assignees
No one assigned
Labels
Canonical by Canonical employees outside the Netplan team community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilvipero @slyon @rkratky