Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Enable Swift Package Manager #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MahmoudFares6700
Copy link

Enable Swift Package Manager

@MahmoudFares6700 MahmoudFares6700 marked this pull request as ready for review August 7, 2024 12:34
Copy link

@PattoMotto PattoMotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't move this out or move to Sources?
image

@MahmoudFares6700
Copy link
Author

Why don't move this out or move to Sources

because it's a nested examples project and we open FloatingPanel.xcworkspace to modified or run not needed to move It

@@ -17,7 +17,7 @@
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleVersion</key>
<string>1</string>
<string>master(675c5ae)</string>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version?

@@ -12,7 +12,7 @@ The new interface displays the related contents and utilities in parallel as a u

s.platform = :ios, "11.0"
s.source = { :git => "https://github.com/careem/FloatingPanel.git", :tag => "v#{s.version}" }
s.source_files = "Framework/Sources/*.swift"
s.source_files = "Sources/FloatingPanel/*.swift"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pod installation is validated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes working but I need to make ENABLE_USER_SCRIPT_SANDBOXING = false if you in project


let package = Package(
name: "FloatingPanel",
platforms: [.iOS("11.0")],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we bump it to "15.8" (and in Podspec as well)?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if we still need an umbrella header and info plist in the package? 🤔

@e-kazakov
Copy link

Why don't move this out or move to Sources?

I'm not sure we need to keep both package and xcodeproj

@nikolaykasyanov
Copy link
Member

nikolaykasyanov commented Aug 9, 2024

I'd like to learn more about this, is it to be used by some existing codebase via SPM, or is it for yet-to-be written new code? In the latter case, wouldn't UIPopoverPresentationController be a better choice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants