-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Enable Swift Package Manager #3
base: master
Are you sure you want to change the base?
Conversation
…/enable-swift-package-manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it's a nested examples project and we open |
@@ -17,7 +17,7 @@ | |||
<key>CFBundleShortVersionString</key> | |||
<string>1.0</string> | |||
<key>CFBundleVersion</key> | |||
<string>1</string> | |||
<string>master(675c5ae)</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version?
@@ -12,7 +12,7 @@ The new interface displays the related contents and utilities in parallel as a u | |||
|
|||
s.platform = :ios, "11.0" | |||
s.source = { :git => "https://github.com/careem/FloatingPanel.git", :tag => "v#{s.version}" } | |||
s.source_files = "Framework/Sources/*.swift" | |||
s.source_files = "Sources/FloatingPanel/*.swift" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pod installation is validated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes working but I need to make ENABLE_USER_SCRIPT_SANDBOXING = false
if you in project
|
||
let package = Package( | ||
name: "FloatingPanel", | ||
platforms: [.iOS("11.0")], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we bump it to "15.8"
(and in Podspec as well)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if we still need an umbrella header and info plist in the package? 🤔
I'm not sure we need to keep both package and xcodeproj |
I'd like to learn more about this, is it to be used by some existing codebase via SPM, or is it for yet-to-be written new code? In the latter case, wouldn't |
Enable Swift Package Manager