Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] Enable Swift Package Manager #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MISC] Enable Swift Package Manager #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,5 @@ fastlane/test_output

# macOS
.DS_Store

.swiftpm/
2 changes: 1 addition & 1 deletion Examples/Samples/Sources/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleVersion</key>
<string>1</string>
<string>master(675c5ae)</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version?

<key>LSRequiresIPhoneOS</key>
<true/>
<key>UILaunchStoryboardName</key>
Expand Down
2 changes: 1 addition & 1 deletion FloatingPanel.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ The new interface displays the related contents and utilities in parallel as a u

s.platform = :ios, "11.0"
s.source = { :git => "https://github.com/careem/FloatingPanel.git", :tag => "v#{s.version}" }
s.source_files = "Framework/Sources/*.swift"
s.source_files = "Sources/FloatingPanel/*.swift"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pod installation is validated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes working but I need to make ENABLE_USER_SCRIPT_SANDBOXING = false if you in project

s.swift_version = "5.0"
s.pod_target_xcconfig = { 'APPLICATION_EXTENSION_API_ONLY' => 'YES' }

Expand Down
143 changes: 81 additions & 62 deletions Framework/FloatingPanel.xcodeproj/project.pbxproj
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 22 additions & 0 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// swift-tools-version:5.8
import PackageDescription

let package = Package(
name: "FloatingPanel",
platforms: [.iOS("11.0")],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we bump it to "15.8" (and in Podspec as well)?

products: [
.library(
name: "FloatingPanel",
targets: ["FloatingPanel"]),
],
dependencies: [],
targets: [
.target(
name: "FloatingPanel",
dependencies: []),
.testTarget(
name: "FloatingPanelTests",
dependencies: ["FloatingPanel"]
)
]
)
0 Framework/Sources/FloatingPanel.h → Sources/FloatingPanel/FloatingPanel.h
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if we still need an umbrella header and info plist in the package? 🤔

File renamed without changes.
0 Framework/Sources/FloatingPanel.swift → Sources/FloatingPanel/FloatingPanel.swift
View file
Open in desktop
File renamed without changes.
0 ...k/Sources/FloatingPanelBackdropView.swift → ...tingPanel/FloatingPanelBackdropView.swift
View file
Open in desktop
File renamed without changes.
0 ...ework/Sources/FloatingPanelBehavior.swift → ...FloatingPanel/FloatingPanelBehavior.swift
View file
Open in desktop
File renamed without changes.
0 ...ork/Sources/FloatingPanelController.swift → ...oatingPanel/FloatingPanelController.swift
View file
Open in desktop
File renamed without changes.
0 Framework/Sources/FloatingPanelLayout.swift → ...s/FloatingPanel/FloatingPanelLayout.swift
View file
Open in desktop
File renamed without changes.
0 ...rk/Sources/FloatingPanelSurfaceView.swift → ...atingPanel/FloatingPanelSurfaceView.swift
View file
Open in desktop
File renamed without changes.
0 .../Sources/FloatingPanelTransitioning.swift → ...ingPanel/FloatingPanelTransitioning.swift
View file
Open in desktop
File renamed without changes.
0 Framework/Sources/FloatingPanelView.swift → ...ces/FloatingPanel/FloatingPanelView.swift
View file
Open in desktop
File renamed without changes.
0 Framework/Sources/GrabberHandleView.swift → ...ces/FloatingPanel/GrabberHandleView.swift
View file
Open in desktop
File renamed without changes.
0 Framework/Sources/Info.plist → Sources/FloatingPanel/Info.plist
View file
Open in desktop
File renamed without changes.
0 Framework/Sources/Logger.swift → Sources/FloatingPanel/Logger.swift
View file
Open in desktop
File renamed without changes.
0 Framework/Sources/UIExtensions.swift → Sources/FloatingPanel/UIExtensions.swift
View file
Open in desktop
File renamed without changes.
0 Framework/Tests/FloatingPanelTests.swift → ...oatingPanelTests/FloatingPanelTests.swift
View file
Open in desktop
File renamed without changes.
0 Framework/Tests/Info.plist → Tests/FloatingPanelTests/Info.plist
View file
Open in desktop
File renamed without changes.