Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinball: Add version 0.3.20201218 #52

Merged
merged 1 commit into from
Jan 15, 2021
Merged

pinball: Add version 0.3.20201218 #52

merged 1 commit into from
Jan 15, 2021

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Dec 20, 2020

Emilia Pinball libre pinball simulator for GNU/Linux

Bug: #51
Origin: https://github.com/CrossStream/meta-games/tree/sandbox/rzr/review/master
Relate-to: https://purl.org/rzr/pinball
Change-Id: Ibf66c90b8697e0e5322c35cadb298fbf3528458a
Signed-off-by: Philippe Coval [email protected]

rzr added a commit to CrossStream/meta-games that referenced this pull request Dec 20, 2020
@rzr
pinball: Add version 0.3.20201218
a0c4412 
Emilia Pinball libre pinball simulator for GNU/Linux

This SDL1.2 game requieres desktop OpenGL,
so a decent GPU support would help
Next version will use SDL-2 and could use wayland only.
Alternative renderers are also welcome (GLES, Vulkan etc).

Bug: cazfi#51
Origin: https://github.com/CrossStream/meta-games/tree/sandbox/rzr/review/master
Forwarded: cazfi#52
Relate-to: https://purl.org/rzr/pinball
Change-Id: Ibf66c90b8697e0e5322c35cadb298fbf3528458a
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/review/master branch from 44326b9 to a0c4412 Compare December 20, 2020 22:23
@rzr rzr changed the title pinball: Add version 0.0.20201218 pinball: Add version 0.3.20201218 Dec 20, 2020
schnitzeltony
schnitzeltony suggested changes Dec 21, 2020
View reviewed changes
recipes-games/pinball/pinball_0.3.20201218.bb Outdated Show resolved Hide resolved
recipes-games/pinball/pinball_0.3.20201218.bb Outdated Show resolved Hide resolved
recipes-games/pinball/pinball_0.3.20201218.bb Outdated Show resolved Hide resolved
recipes-games/pinball/pinball_0.3.20201218.bb Outdated Show resolved Hide resolved
recipes-games/pinball/pinball_0.3.20201218.bb Show resolved Hide resolved
recipes-games/pinball/pinball_0.3.20201218.bb Outdated
PACKAGES += "${PN}-staticdev"
PACKAGES += "${PN}-dbg"
PACKAGES += "${PN}-dev"
PACKAGES += "${PN}-data"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you set many packages that are created by default? The only line necessary I see is

PACKAGES += "${PN}-data" - and I am not sure if that is necessary either or do you want to share data with other recipes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinball-dev will be used for other tables (gnu & hurd) to come later

recipes-games/pinball/pinball_0.3.20201218.bb
PACKAGES += "${PN}-data"

inherit pkgconfig autotools-brokensep
REMOVE_LIBTOOL_LA = "0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Anything broken without it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well build from outside directory did not work, so I used
https://git.congatec.com/yocto/poky/commit/069de520ec864fc78084e8f1ddfb20edaab55f5e
la file should be preserved for plugin loader

recipes-games/pinball/pinball_0.3.20201218.bb Show resolved Hide resolved
recipes-games/pinball/pinball_0.3.20201218.bb
"

FILES_${PN} = "\
${libdir}/${PN}/libModule*.so* \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong and makes

INSANE_SKIP_${PN} = "dev-so"

below necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are tables behaviors plugins

recipes-games/pinball/pinball_0.3.20201218.bb Outdated Show resolved Hide resolved
rzr added a commit to CrossStream/meta-games that referenced this pull request Dec 26, 2020
@rzr
pinball: Add version 0.3.20201218
160a992 
Emilia Pinball libre pinball simulator for GNU/Linux

This SDL1.2 game requieres desktop OpenGL,
so a decent GPU support would help
Next version will use SDL-2 and could use wayland only.
Alternative renderers are also welcome (GLES, Vulkan etc).

Extra notes:

- autotools-brokensep is needed because it did not build out of sources,
- la files should be preserved for loader
- dev package will be needed to build other tables

Origin: https://github.com/CrossStream/meta-games/tree/sandbox/rzr/review/master
Bug: cazfi#51
Bug-pinball: adoptware/pinball#9
Forwarded: cazfi#52
Relate-to: https://purl.org/rzr/pinball
See-Also: https://patchwork.openembedded.org/patch/114267/
Change-Id: Ibf66c90b8697e0e5322c35cadb298fbf3528458a
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/review/master branch from a0c4412 to 160a992 Compare December 26, 2020 12:02
rzr added a commit to CrossStream/meta-games that referenced this pull request Dec 26, 2020
@rzr
pinball: Add version 0.3.20201218
38acae0 
Emilia Pinball libre pinball simulator for GNU/Linux

This SDL1.2 game requieres desktop OpenGL,
so a decent GPU support would help
Next version will use SDL-2 and could use wayland only.
Alternative renderers are also welcome (GLES, Vulkan etc).

Extra notes:

- autotools-brokensep is needed because it did not build out of sources,
- la files should be preserved for loader
- dev package will be needed to build other tables

Origin: https://github.com/CrossStream/meta-games/tree/sandbox/rzr/review/master
Bug: cazfi#51
Bug-pinball: adoptware/pinball#9
Forwarded: cazfi#52
Relate-to: https://purl.org/rzr/pinball
See-Also: https://patchwork.openembedded.org/patch/114267/
Change-Id: Ibf66c90b8697e0e5322c35cadb298fbf3528458a
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/review/master branch from 160a992 to 38acae0 Compare December 26, 2020 13:23
@cazfi
Copy link
Owner

cazfi commented Jan 3, 2021

Latest version ok for @schnitzeltony ?

@schnitzeltony
Copy link
Contributor

Hmm... still looks ugly to me but I don't want to block this - it builds without issues for me.
Suggestion: Apply it as is and once I have some space cycles I'll send a follow up

@rzr
Copy link
Contributor Author

rzr commented Jan 3, 2021

is it just a question of style ? if yes I am flexible and I can align to your other recipes

rzr added a commit to CrossStream/meta-games that referenced this pull request Jan 4, 2021
@rzr
pinball: Add version 0.3.20201218
25364dd 
Emilia Pinball libre pinball simulator for GNU/Linux

This SDL1.2 game requieres desktop OpenGL,
so a decent GPU support would help
Next version will use SDL-2 and could use wayland only.
Alternative renderers are also welcome (GLES, Vulkan etc).

Extra notes:

- packaging is aligned to Debian
- autotools-brokensep is needed because it did not build out of sources,
- la files should be preserved for loader
- dev package will be needed to build other tables

Origin: https://github.com/CrossStream/meta-games/tree/sandbox/rzr/review/master
Bug: cazfi#51
Bug-pinball: adoptware/pinball#9
Forwarded: cazfi#52
Relate-to: https://purl.org/rzr/pinball
See-Also: https://patchwork.openembedded.org/patch/114267/
Change-Id: Ibf66c90b8697e0e5322c35cadb298fbf3528458a
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/review/master branch from 38acae0 to 25364dd Compare January 4, 2021 09:14
@rzr
Copy link
Contributor Author

rzr commented Jan 4, 2021

I linted a bit the recipe and updated commit message to tell that packaging is aligned to Debian's one

But I am open to suggestions at

Related issue: adoptware/pinball#9

@rzr
pinball: Add version 0.3.20201218
128af8b 
Emilia Pinball libre pinball simulator for GNU/Linux

This SDL1.2 game requieres desktop OpenGL,
so a decent GPU support would help
Next version will use SDL-2 and could use wayland only.
Alternative renderers are also welcome (GLES, Vulkan etc).

Extra notes:

- packaging is aligned to Debian
- autotools-brokensep is needed because it did not build out of sources,
- la files should be preserved for loader
- dev package will be needed to build other tables

Origin: https://github.com/CrossStream/meta-games/tree/sandbox/rzr/review/master
Bug: cazfi#51
Bug-pinball: adoptware/pinball#9
Forwarded: cazfi#52
Relate-to: https://purl.org/rzr/pinball
See-Also: https://patchwork.openembedded.org/patch/114267/
Change-Id: Ibf66c90b8697e0e5322c35cadb298fbf3528458a
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/review/master branch from 25364dd to 128af8b Compare January 5, 2021 22:48
@schnitzeltony
Copy link
Contributor

To make it clear:

  • I am still not convinced that re-inventing all standard packages is the right thing to do
  • This is not my layer and it is something just for fun. So I am not in the position to block and don't have much time to discuss issues
  • Am interested in this recipe - a pinball is something missing definitely to waste a little time on it

@cazfi Suggested this earlier: Take it as is and if somebody wants to rework it later - feel free. I did a build test before my previous comment and found no issues. Sorry but the decision remains upon you

@rzr
Copy link
Contributor Author

rzr commented Jan 6, 2021 •
edited
Loading

ok I am fine with later improvements, please merge, then let me submit (in other PR) other tables recipes before touching those files

@rzr
Copy link
Contributor Author

rzr commented Jan 10, 2021

or do you prefer the extra tables in same PR ?

@rzr rzr mentioned this pull request Jan 10, 2021
Closed
@cazfi
Copy link
Owner

cazfi commented Jan 10, 2021

I hope to have time to look this next Thursday or Friday.

@rzr
Copy link
Contributor Author

rzr commented Jan 10, 2021

ok great ! I'll wait for you I am not hurry :)

@cazfi
Copy link
Owner

cazfi commented Jan 15, 2021

I'm not very happy with the name of the recipe being just 'pinball', for the namespace reasons. It's not the only pinball game out there. However, seeing that it's its project name in sourceforge too, I think we can accept that.

In general my conclusion is that this is already, in its current form, an improvement to meta-games, so I'm about to merge this.

@cazfi cazfi merged commit 13c4a63 into cazfi:master Jan 15, 2021
@rzr
Copy link
Contributor Author

rzr commented Jan 15, 2021

well I try to align the most to other distros it would be nice to not drift too much

Follow up to this change is:
#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schnitzeltony schnitzeltony schnitzeltony requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzr @cazfi @schnitzeltony