Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-source behave tests from OpenJDK for regression suite #61

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

jmtd
Copy link
Collaborator

@jmtd jmtd commented Mar 21, 2024

The GHA job up until now relied upon running the externally-defined behave tests for the OpenJDK container images (runtime variant).

The external test suite is primarily designed to cover the OpenJDK image, and not to provide coverage of all of the behave-test-steps.

Rework the job to operate on a local copy of these behave tests. (Also do a bit of spring-cleaning)

Future work can adjust the feature files to provide better coverage for the steps defined in this repository.

The GHA job up until now relied upon running the externally-defined
behave tests for the OpenJDK container images (runtime variant).

The external test suite is primarily designed to cover the OpenJDK
image, and not to provide coverage of all of the behave-test-steps.

Rework the job to operate on a local copy of these behave tests.
(Also do a bit of spring-cleaning)

Future work can adjust the feature files to provide better coverage
for the steps defined in this repository.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd changed the title In-source behave tests from OpenJDK for regression suite WIP: In-source behave tests from OpenJDK for regression suite Mar 21, 2024
@jmtd jmtd marked this pull request as ready for review March 21, 2024 16:26
See also PR cekit#60.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd changed the title WIP: In-source behave tests from OpenJDK for regression suite In-source behave tests from OpenJDK for regression suite Mar 22, 2024
@jmtd
Copy link
Collaborator Author

jmtd commented Mar 22, 2024

Thanks @rnc , I've untagged it "WIP", please merge at your convenience

@rnc rnc merged commit 8a69fd6 into cekit:v1 Mar 23, 2024
1 check passed
@jmtd jmtd deleted the local-test-suite branch March 25, 2024 09:28
jmtd added a commit to jmtd/behave-test-steps that referenced this pull request Nov 21, 2024
* In-source behave tests from OpenJDK for regression suite

The GHA job up until now relied upon running the externally-defined
behave tests for the OpenJDK container images (runtime variant).

The external test suite is primarily designed to cover the OpenJDK
image, and not to provide coverage of all of the behave-test-steps.

Rework the job to operate on a local copy of these behave tests.
(Also do a bit of spring-cleaning)

Future work can adjust the feature files to provide better coverage
for the steps defined in this repository.

Signed-off-by: Jonathan Dowland <[email protected]>

* Test to exercise 'File . should contain'

See also PR cekit#60.

Signed-off-by: Jonathan Dowland <[email protected]>

---------

Signed-off-by: Jonathan Dowland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants