feat(share/availability)!: Store success results for light availability #3887
Conversation
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3887 +/- ##
==========================================
+ Coverage 44.83% 45.27% +0.44%
==========================================
Files 265 309 +44
Lines 14620 21814 +7194
==========================================
+ Hits 6555 9877 +3322
- Misses 7313 10871 +3558
- Partials 752 1066 +314 ☔ View full report in Codecov by Sentry. |
|
Why do we store successful sampling results? I know we wanted to do this, but I think we should wait to do it. My concern is mainly about not doing this together with the reconstruction and the new light node storage that would keep the bitmap-like state. If think you we need to do it earlier, then please explain. |
We need to store list of sampled coordinates for pruning. We would need to know coordinates to delete samples from blockstore by cid |
walldiss
force-pushed
the
store-samples-coords
branch
from
fc26162
to
cd5fe25
Compare
walldiss
force-pushed
the
store-samples-coords
branch
from
cd5fe25
to
0c2113b
Compare
| if err != nil { | ||
| return err | ||
| } | ||
| // Verify total samples count. | ||
| totalSamples := len(samples.Remaining) + len(samples.Available) | ||
| if totalSamples != int(la.params.SampleAmount) { |
There was a problem hiding this comment.
nit: alternatively could have a validation func on SamplingResult
non blockin
Wondertan
changed the title
Store coordinates of successful sampling calls