Cancel streamed downloads & fix progress for downloads

[kuhnroyal]

New Pull Request Checklist

• I have read the Documentation
• I have searched for a similar pull request in the project and found none
• I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
• I have added the required tests to prove the fix/feature I'm adding
• I have updated the documentation (if necessary)
• I have run the tests without failures
• I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

[AlexV525]

Before review: Could we abstract the implementation of this cancellation above the specific adapter? If we're doing this in adapters, then every adapter needs to consider the same functionality.

[kuhnroyal]

I will see what I can do, but I already know that this is basically not supported on web.

[AlexV525]

I will see what I can do, but I already know that this is basically not supported on web.

Sure, but we have thousands of adapters around the world. :)

[kuhnroyal]

Before review: Could we abstract the implementation of this cancellation above the specific adapter? If we're doing this in adapters, then every adapter needs to consider the same functionality.

This is hard without breaking. If we want to do this in the DioMixin we have no access to the underlying http implementation and can not close the stream/connection. We would have to pass some new argument to the adapters or extend ResponseBody with a new close function. But this seems like an issue for dio 6.

[kuhnroyal]

This is a lot more complex. We have completely different behavior for different adapters when doing streamed responses/downloads and most of it can not be abstracted away.

For IOHttpClientAdapter we have a ResponseBody with a stream so the await dio.get succeeds after the connection is established with a Response and the cancellation exception is thrown on the stream.

For BrowserHttpClientAdapter we have a ResponseBody with bytes and the adapter has to wait until everything is received, before completing with a response. So the cancellation exception is thrown on the await dio.get.
And there is no way to access other information from the XHR when aborting.

[AlexV525]

What about the HTTP/2 adapter?

[kuhnroyal]

What about the HTTP/2 adapter?

Fixed it there as well. I think we should merge this and brain storm if we can abstract this away separately.

[AlexV525]

Fixed it there as well.

Marvelous!

[AlexV525]

[AlexV525]

We have asynchronous gaps between this call and other awaits. Can we do this earlier or separated?

For new comment

[AlexV525]

@kuhnroyal Is this still on your track? The last time I review this it only remains a few nits.

[kuhnroyal]

@kuhnroyal Is this still on your track? The last time I review this it only remains a few nits.

Yea

[kuhnroyal]

Superseeded by #2068 due to lots of updates on main