-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix streamed response cancellation and progress #2068
Conversation
The failing tests happen with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome. But I'm still confused by the changes of http2
, from our changes it shouldn't cause the min check to fail.
Yea, I am still not sure what the problem is. |
This was the failing run: https://github.com/cfug/dio/pull/2068/checks?check_run_id=19725552125 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
CancelToken
be able to cancel response streams fromResponseType.stream
requests #2025This is a new approach that handles both IO & HTTP/2 adapters.
I also moved the
receiveTimeout
handling for IO & HTTP2 to the new helper.New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)CHANGELOG.md
in the corresponding packageAdditional context and info (if any)