Icon update PR made by bezier-asset main #2378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2378 +/- ##
=======================================
Coverage 83.86% 83.86%
=======================================
Files 140 140
Lines 2919 2919
Branches 879 892 +13
=======================================
Hits 2448 2448
+ Misses 466 441 -25
- Partials 5 30 +25 ☔ View full report in Codecov by Sentry. |
yangwooseong
force-pushed
the
icon-update-main
branch
from
4dd782b to
894a29b
Compare
6 tasks
yangwooseong
added a commit
that referenced
this pull request
Jul 23, 2024
<!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> <!-- Fixes #0000 --> - None ## Summary <!-- Please brief explanation of the changes made --> - #2378 에서 아이콘 변경 내역이 PR 본문에 잘못 나오고 changeset push 가 안되고 있는 것을 수정합니다. ## Details <!-- Please elaborate description of the changes --> - PR본문을 추가하는 워크플로우에서 checkout 액션의 fetch-depth가 default(=1) 이라서 파일이 변경된 것으로 인식하지 않고 추가된것으로 인식해서 모두 Add로 나왔습니다. 0으로 바꿔서 모든 커밋 히스토리를 가져오도록 수정했습니다. - 누락된 changeset commit push 를 추가합니다. ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> - No ## References <!-- Please list any other resources or points the reviewer should be aware of --> - fork한 레포에서 테스트했을 때 잘 나오는 것을 확인했습니다 -> yangwooseong#168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icon update is ready to be merged! 🎉