Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add IconQuoteLarge #613

Merged
merged 2 commits into from
Sep 27, 2023
Merged

feat(icons): add IconQuoteLarge #613

merged 2 commits into from
Sep 27, 2023

Conversation

kaloster
Copy link
Contributor

Add IconQuoteLarge Large and X-Large

Summary

Icon
Quote Icon for Citation Tool

Component Name: IconQuoteLarge

Component Requirements:
Icons can be found on the Google Drive:

Team(s) Requesting: CZI SC


Related tickets:

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on the first PR to SDS, @kaloster ! Really appreciate your contribution 🎉 !

Copy link
Contributor

@masoudmanson masoudmanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution to the SDS. The SVG file only need a minor modification; otherwise, it LGTM. 🎉

@kaloster kaloster merged commit b14234f into main Sep 27, 2023
7 checks passed
@kaloster kaloster deleted the kaloster/add-citation-icon branch September 27, 2023 19:39
@kaloster
Copy link
Contributor Author

@masoudmanson sorry saw this too late - happy to push any changes to the SVG

Copy link
Contributor

@masoudmanson masoudmanson Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you delete the fill attribute from the path tag, the icon will take on colors other than the Primary blue.
Currently, it only displays the blur color.

Screenshot 2023-09-27 at 3 37 16 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha! on it

@masoudmanson
Copy link
Contributor

@masoudmanson sorry saw this too late - happy to push any changes to the SVG

That's okay. You can make a new PR and fix the SVG file. Thank you very much. 💯 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants