Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add IconQuoteLarge #613

Merged
merged 2 commits into from
Sep 27, 2023
Merged

feat(icons): add IconQuoteLarge #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da335f6
feat(icons): add citation icon
kaloster Sep 26, 2023
685d6a6
feat(icons): added IconQuoteLarge
kaloster Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/components/src/common/svgs/IconQuoteLarge.svg
View file
Open in desktop
Copy link
Contributor

@masoudmanson masoudmanson Sep 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you delete the fill attribute from the path tag, the icon will take on colors other than the Primary blue.
Currently, it only displays the blur color.

Screenshot 2023-09-27 at 3 37 16 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha! on it

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions packages/components/src/core/Icon/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ import { ReactComponent as IconProjectPrivateLarge } from "../../common/svgs/Ico
import { ReactComponent as IconProjectPublicLarge } from "../../common/svgs/IconProjectPublicLarge.svg";
import { ReactComponent as IconPuzzlePieceSmall } from "../../common/svgs/IconPuzzlePieceSmall.svg";
import { ReactComponent as IconQuestionMarkLarge } from "../../common/svgs/IconQuestionMarkLarge.svg";
import { ReactComponent as IconQuoteLarge } from "../../common/svgs/IconQuoteLarge.svg";
import { ReactComponent as IconRefreshLarge } from "../../common/svgs/IconRefreshLarge.svg";
import { ReactComponent as IconRefreshSmall } from "../../common/svgs/IconRefreshSmall.svg";
import { ReactComponent as IconSaveLarge } from "../../common/svgs/IconSaveLarge.svg";
Expand Down Expand Up @@ -184,6 +185,7 @@ export interface IconNameToSizes {
projectPublic: "l" | "xl";
puzzlePiece: "xs" | "s";
questionMark: "l" | "xl";
quote: "l" | "xl";
refresh: "xs" | "s" | "l" | "xl";
save: "l" | "xl";
search: "xs" | "s" | "l" | "xl";
Expand Down Expand Up @@ -482,6 +484,10 @@ export const iconMap: Props = {
largeIcon: IconQuestionMarkLarge,
smallIcon: null,
},
quote: {
largeIcon: IconQuoteLarge,
smallIcon: null,
},
refresh: {
largeIcon: IconRefreshLarge,
smallIcon: IconRefreshSmall,
Expand Down
Loading