feat(styles/common): mobile font styles #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
force-pushed
the
jeremy/mobile-font-styles
branch
from
3a736a2
to
9c1a8e4
Compare
masoudmanson
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Great PR, @codemonkey800! ✨✨✨
Thank you for taking the initiative to add the Narrow font styles, it looks fantastic overall. I’ve left a couple of minor comments for your review. 🥳🎉😍🙏🏻
|
@masoudmanson thank you for all the comments! I've renamed everything to use wide and narrow semantics now |
masoudmanson
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Thank you so much, @codemonkey800 , for updating the names and refactoring the PR. LGTM! 🥳🎉
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds typography styles for mobile fonts based on the narrow font stylings defined here:
https://www.figma.com/design/zedDsBDlmkLrKBTuJ4FAz7/Science-Design-System-(v2)?node-id=9720-9277&node-type=canvas&t=EdW9v01y3dkABpCN-0