Various fixes and improvements #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If argument is falsy, set `master` to `null` to avoid false-positives. Changed: - Fixed edge case where `hasMaster()` compares `0` to `null`. - Reset `masterObject` when `master` changes to avoid conflicts.
Set `master` to `null` instead of `0`.
…tion` When collection is displayed on one page, orphaned descendants should be displayed. Previously, they were only displayed in pagination was enabled.
Changed: - Added method `hasMasterObject()`. - Added methods `loadHierarchy()` and `loadSiblings()`. - Fixed type-hints related to `ModelInterface` and `HierarchicalInterface`.
Decoupled common list actions, object actions, and orders.
They described what a constructor is in general and not what the classes' constructors do.
mcaskill
force-pushed
the
feature/various-fixes
branch
from
a6a380c to
ca77b4d
Compare
The `AssetsBuilder` now accepts a base path from its constructor. Replaced relative base path assumption (`dirname(__DIR__, 7)`) with either: 1. Explicit base path (see constructor parameter), or 2. Implicit base path (the current working directory). By default, the base path is explicitly set to the `AppConfig`'s base path. This ensures relative asset paths are loaded according a more reliable base path.
Only apply `^` operator (minimum values of size) if both width and height are supplied, otherwise the image will be cropped to a square.
mcaskill
force-pushed
the
feature/various-fixes
branch
from
ca77b4d to
f2cdc77
Compare
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin
Fix and improve base path in
AssetsBuilder.The
AssetsBuildernow accepts a base path from its constructor.Replaced relative base path assumption (
dirname(__DIR__, 7)) with dedicated base path, either:By default, the base path is explicitly set to the
AppConfig's base path.This ensures relative asset paths are loaded according a more reliable base path.
Ensure master object exists in
HierarchicalOjectProperty.Remove default constructor descriptions from
AssetsBuilderandSelectizeRenderer.CMS
HierarchicalSectionTableWidget.masterfilter for menu items inSectionInterfaceadmin metadata.SectionInterfaceadmin metadata.Object
Improve
Hierarchicalmixin.hasMasterObject().loadHierarchy()andloadSiblings().Fix missing orphaned descendants in
HierarchicalCollection.When collection is displayed on one page, orphaned descendants should be displayed.
Previously, they were only displayed in pagination was enabled.
Fix bad hierarchy repair in
HierarchicalCollection.mastertonullinstead of0.Filter argument of
HierarchicalTrait::setMaster().hasMaster()compares0tonull.masterObjectwhenmasterchanges to avoid conflicts.Image