Initial profile changes #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhand2
reviewed
Sep 12, 2023
zhalvorsen
reviewed
Sep 20, 2023
jhand2
requested changes
Sep 29, 2023
premalathak12
force-pushed
the
emulator-client
branch
from
43082cd
to
e5dca32
Compare
jhand2
reviewed
Oct 2, 2023
verification/emulator.go
Outdated
Comment on lines
135
to
140
| var i int | ||
| for i = 0; i < len(buf); i++ { | ||
| fmt.Print(buf[i]) | ||
| fmt.Print(",") | ||
| } | ||
|
|
verification/verification_test.go
Outdated
| for i := 0; i < len(support_needed); i++ { | ||
| support := reflect.Indirect(value).FieldByName(support_needed[i]) | ||
| if !support.Bool() { | ||
| return nil, errors.New("Error in creating dpe instances - supported feature is not enabled in emulator") | ||
| } | ||
| } | ||
| var instance TestDPEInstance = &DpeEmulator{exe_path: *target_exe} | ||
| instance.SetSupport(support) |
There was a problem hiding this comment.
Support cannot be set on the emulator. Either the target supports what is needed or it doesn't. So I think this line can be removed and then the SetSupport target API can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr contains the initial changes for testing profile command.