Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update entry file & README to fix deprecations #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeremyeaton89
Copy link

Just wanted to get this working out of the box for React 16. Took a look at getting the examples to work, but solution seemed non trivial. Hopefully this works for now!

ToolTip.ios.js Outdated
@@ -7,50 +7,50 @@ var {
NativeModules,
findNodeHandle,
} = require('react-native');
var PropTypes = require('prop-types');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add this to package.json?

Also it would be awesome to have those vars as const/let.

@jeremyeaton89
Copy link
Author

any chance this can be merged?

happy new year! :)

@chirag04
Copy link
Owner

chirag04 commented Feb 9, 2018

Is this still required? Will need rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants